Bug 258794 - devel/icu: update to 70.1
Summary: devel/icu: update to 70.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL: https://icu.unicode.org/download/70
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2021-09-30 01:43 UTC by Jan Beich
Modified: 2021-10-28 16:48 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (office)
antoine: exp-run+


Attachments
v0 (RC1, USE_GITHUB) (2.39 KB, patch)
2021-09-30 01:43 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-09-30 01:43:16 UTC
Created attachment 228266 [details]
v0 (RC1, USE_GITHUB)
Comment 1 Dima Panov freebsd_committer 2021-10-01 19:22:56 UTC
(In reply to Jan Beich from comment #0)
Why not follow pregenerated authoritative release tarball as it was used before and switch to GH autopacked/autonamed scheme?
Comment 2 Jan Beich freebsd_committer 2021-10-01 22:11:22 UTC
(In reply to Dima Panov from comment #1)
- Release downloads are published way later
- LFS mainly affected ICU4J (Java API) while this port builds ICU4C (C/C++ API)
- docs/processes/release/tasks/publish/index.md says LFS is nowadays supported by GitHub archives
- For the purpose of exp-run it doesn't matter (similar to PORTREVISION bumps)
Comment 3 Jan Beich freebsd_committer 2021-10-01 22:18:31 UTC
Actually, I don't understand the 2nd part of the question ("switch to ...") in comment 1.
Comment 5 commit-hook freebsd_committer 2021-10-06 14:54:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2c2eb4692242d0f7c9e125920a712bc8f4ec0154

commit 2c2eb4692242d0f7c9e125920a712bc8f4ec0154
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-10-06 14:22:52 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-10-06 14:52:33 +0000

    devel/php*-intl: unbreak build with ICU 70

    In file included from breakiterator/breakiterator_class.cpp:21:
    breakiterator/codepointiterator_internal.h:40:17: error: virtual function 'operator==' has a different return type ('UBool' (aka 'signed char')) than the function it overrides (which has return type 'bool')
                    virtual UBool operator==(const BreakIterator& that) const;
                            ~~~~~ ^
    /usr/local/include/unicode/brkiter.h:127:18: note: overridden virtual function is here
        virtual bool operator==(const BreakIterator&) const = 0;
                ~~~~ ^

    PR:             258794
    Reported by:    antoine (via exp-run)

 devel/php73-intl/files/patch-icu70 (new) | 38 ++++++++++++++++++++++++++++++++
 devel/php74-intl/files/patch-icu70 (new) | 38 ++++++++++++++++++++++++++++++++
 devel/php80-intl/files/patch-icu70 (new) | 38 ++++++++++++++++++++++++++++++++
 3 files changed, 114 insertions(+)
Comment 6 Antoine Brodin freebsd_committer 2021-10-12 17:43:38 UTC
Exp-run looks fine
Comment 7 Jan Beich freebsd_committer 2021-10-28 01:02:30 UTC
https://github.com/unicode-org/icu/releases/tag/release-70-1 currently lacks manually generated tarballs (under Assets).
Comment 8 commit-hook freebsd_committer 2021-10-28 16:47:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f34ece3aa6a292628ea75c0e4dd2a04d879ab0a3

commit f34ece3aa6a292628ea75c0e4dd2a04d879ab0a3
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-04-08 00:10:27 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-10-28 16:37:30 +0000

    devel/icu: update to 70.1

    Changes:        https://github.com/unicode-org/icu/releases/tag/release-70-1
    Reported by:    GitHub (watch releases)
    PR:             258794
    Exp-run by:     antoine

 archivers/unarchiver/Makefile                  | 2 +-
 audio/musicpd/Makefile                         | 1 +
 audio/ncmpcpp/Makefile                         | 2 +-
 databases/couchdb3/Makefile                    | 1 +
 databases/evolution-data-server/Makefile       | 1 +
 databases/firebird25-server/Makefile           | 1 +
 databases/firebird30-server/Makefile           | 1 +
 databases/firebird40-server/Makefile           | 2 +-
 databases/kbibtex/Makefile                     | 2 +-
 databases/kdb/Makefile                         | 2 +-
 databases/mysql80-client/Makefile              | 2 +-
 databases/mysql80-server/Makefile              | 2 +-
 databases/postgresql10-server/Makefile         | 2 +-
 databases/postgresql11-server/Makefile         | 2 +-
 databases/postgresql12-server/Makefile         | 2 +-
 databases/postgresql13-server/Makefile         | 2 +-
 databases/postgresql14-server/Makefile         | 2 +-
 databases/postgresql96-server/Makefile         | 2 +-
 databases/sqlite3/Makefile                     | 2 +-
 databases/tarantool/Makefile                   | 1 +
 databases/xtrabackup8/Makefile                 | 2 +-
 deskutils/calibre/Makefile                     | 1 +
 deskutils/copyq/Makefile                       | 1 +
 deskutils/osmo/Makefile                        | 2 +-
 deskutils/peaclock/Makefile                    | 2 +-
 devel/boost-libs/Makefile                      | 2 +-
 devel/dee/Makefile                             | 2 +-
 devel/fbthrift/Makefile                        | 1 +
 devel/icu-le-hb/Makefile                       | 1 +
 devel/icu/Makefile                             | 2 +-
 devel/icu/distinfo                             | 6 +++---
 devel/icu/pkg-plist                            | 2 ++
 devel/kiwix-lib/Makefile                       | 2 +-
 devel/libical/Makefile                         | 2 +-
 devel/libphonenumber/Makefile                  | 1 +
 devel/libzim/Makefile                          | 1 +
 devel/objecthash/Makefile                      | 2 +-
 devel/php73-intl/Makefile                      | 1 +
 devel/php74-intl/Makefile                      | 1 +
 devel/php80-intl/Makefile                      | 1 +
 devel/py-pyicu/Makefile                        | 2 +-
 devel/qt5-core/Makefile                        | 2 +-
 devel/ticcutils/Makefile                       | 1 +
 dns/libpsl/Makefile                            | 2 +-
 editors/libreoffice/Makefile                   | 3 ++-
 editors/libreoffice6/Makefile                  | 3 ++-
 editors/poedit/Makefile                        | 2 +-
 finance/gnucash/Makefile                       | 1 +
 games/0ad/Makefile                             | 2 +-
 games/an/Makefile                              | 2 +-
 games/easyrpg-player/Makefile                  | 2 +-
 games/liblcf/Makefile                          | 2 +-
 games/libretro-play/Makefile                   | 2 +-
 games/openrct2/Makefile                        | 2 +-
 games/openttd/Makefile                         | 1 +
 games/widelands/Makefile                       | 2 +-
 graphics/cfdg/Makefile                         | 1 +
 graphics/darktable/Makefile                    | 2 +-
 graphics/dcmtk/Makefile                        | 2 +-
 graphics/imv/Makefile                          | 1 +
 graphics/libcdr01/Makefile                     | 1 +
 graphics/libfreehand/Makefile                  | 2 +-
 graphics/libzmf/Makefile                       | 2 +-
 graphics/maim/Makefile                         | 2 +-
 graphics/openfx-arena/Makefile                 | 2 +-
 graphics/osg/Makefile                          | 2 +-
 graphics/tesseract/Makefile                    | 2 +-
 irc/znc-push/Makefile                          | 2 +-
 irc/znc/Makefile                               | 2 +-
 java/openjfx14/Makefile                        | 2 +-
 lang/gnustep-base/Makefile                     | 2 +-
 lang/hermes/Makefile                           | 1 +
 lang/parrot/Makefile                           | 2 +-
 lang/spidermonkey60/Makefile                   | 2 +-
 lang/spidermonkey78/Makefile                   | 2 +-
 lang/v8/Makefile                               | 1 +
 mail/cyrus-imapd30/Makefile                    | 2 +-
 mail/cyrus-imapd32/Makefile                    | 2 +-
 mail/cyrus-imapd34/Makefile                    | 2 +-
 mail/dovecot-fts-xapian/Makefile               | 1 +
 mail/dovecot/Makefile                          | 1 +
 mail/evolution-ews/Makefile                    | 1 +
 mail/evolution/Makefile                        | 1 +
 mail/exim/Makefile                             | 2 +-
 mail/geary/Makefile                            | 1 +
 mail/libvmime/Makefile                         | 2 +-
 mail/postfix-current/Makefile                  | 2 +-
 mail/postfix/Makefile                          | 2 +-
 mail/rspamd-devel/Makefile                     | 2 +-
 mail/rspamd/Makefile                           | 1 +
 mail/sendmail-devel/Makefile                   | 2 +-
 mail/sendmail/Makefile                         | 2 +-
 mail/thunderbird/Makefile                      | 2 +-
 math/R/Makefile                                | 2 +-
 math/libqalculate/Makefile                     | 2 +-
 math/py-rpy2/Makefile                          | 1 +
 math/sage/Makefile                             | 2 +-
 misc/sword/Makefile                            | 2 +-
 misc/xiphos/Makefile                           | 2 +-
 multimedia/aegisub/Makefile                    | 2 +-
 multimedia/subtitlecomposer/Makefile           | 1 +
 net-im/dino/Makefile                           | 1 +
 net/freerdp/Makefile                           | 1 +
 net/openldap24-server/Makefile                 | 2 +-
 net/openldap25-server/Makefile                 | 2 +-
 net/samba412/Makefile                          | 2 +-
 net/samba413/Makefile                          | 2 +-
 net/yaz/Makefile                               | 1 +
 net/zebra-server/Makefile                      | 2 +-
 news/tin/Makefile                              | 2 +-
 print/harfbuzz-icu/Makefile                    | 2 +-
 print/libmspub01/Makefile                      | 2 +-
 print/miktex/Makefile                          | 2 +-
 print/scribus-devel/Makefile                   | 2 +-
 print/tex-xetex/Makefile                       | 2 +-
 print/texlive-base/Makefile                    | 2 +-
 science/orthanc-dicomweb/Makefile              | 1 +
 science/orthanc-webviewer/Makefile             | 1 +
 science/orthanc/Makefile                       | 1 +
 science/py-tensorflow/Makefile                 | 2 +-
 sysutils/calamares/Makefile                    | 1 +
 sysutils/gdisk/Makefile                        | 1 +
 sysutils/ltfs/Makefile                         | 1 +
 sysutils/tracker-miners/Makefile               | 2 +-
 sysutils/tracker/Makefile                      | 2 +-
 sysutils/tracker3/Makefile                     | 1 +
 textproc/R-cran-stringi/Makefile               | 1 +
 textproc/dwdiff/Makefile                       | 2 +-
 textproc/gitlab-elasticsearch-indexer/Makefile | 2 +-
 textproc/gspell/Makefile                       | 2 +-
 textproc/libe-book/Makefile                    | 2 +-
 textproc/libfolia/Makefile                     | 1 +
 textproc/libqxp/Makefile                       | 2 +-
 textproc/libvisio01/Makefile                   | 2 +-
 textproc/nuspell/Makefile                      | 1 +
 textproc/raptor2/Makefile                      | 2 +-
 textproc/rubygem-charlock_holmes/Makefile      | 2 +-
 textproc/ucto/Makefile                         | 1 +
 textproc/xalan-c/Makefile                      | 2 +-
 textproc/zorba/Makefile                        | 2 +-
 www/chromium/Makefile                          | 1 +
 www/epiphany/Makefile                          | 1 +
 www/firefox-esr/Makefile                       | 2 +-
 www/firefox/Makefile                           | 1 +
 www/node/Makefile                              | 1 +
 www/node10/Makefile                            | 2 +-
 www/node14/Makefile                            | 1 +
 www/node16/Makefile                            | 1 +
 www/pecl-http/Makefile                         | 2 +-
 www/qt5-webkit/Makefile                        | 2 +-
 www/webkit2-gtk3/Makefile                      | 1 +
 x11-toolkits/gnustep-gui/Makefile              | 2 +-
 x11-toolkits/tepl/Makefile                     | 2 +-
 x11-toolkits/tepl6/Makefile                    | 1 +
 x11-toolkits/vte3/Makefile                     | 1 +
 x11/gnome-shell/Makefile                       | 2 +-
 x11/slop/Makefile                              | 1 +
 157 files changed, 162 insertions(+), 103 deletions(-)