Bug 258999 - comms/spandsp: Update to 3.0.0
Summary: comms/spandsp: Update to 3.0.0
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-10-08 04:22 UTC by Dustin Marquess
Modified: 2021-10-15 10:29 UTC (History)
2 users (show)

See Also:


Attachments
spandsp update patch (6.03 KB, patch)
2021-10-08 04:22 UTC, Dustin Marquess
no flags Details | Diff
Fixed patch (6.67 KB, patch)
2021-10-13 21:43 UTC, Dustin Marquess
no flags Details | Diff
Proposed patch (6.10 KB, patch)
2021-10-14 11:54 UTC, Fernando Apesteguía
no flags Details | Diff
Proposed patch (6.19 KB, patch)
2021-10-14 13:11 UTC, Fernando Apesteguía
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin Marquess 2021-10-08 04:22:37 UTC
Created attachment 228509 [details]
spandsp update patch

FreeSWITCH now requires a newer version of SpanDSP, one that they themselves seem to be updating in their GitHub account.


Sadly, they haven't tagged any released yet nor actually released any, so I'm having to go by commit tag  for now.
Comment 1 Fernando Apesteguía freebsd_committer 2021-10-08 06:05:15 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A:  Makefile: [8]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
 Makefile: [10]: contiguous blank lines (> 1 lines) found.
 Makefile: extra item "GITHUB_COMMIT" placed in the PORTNAME section.
 Makefile: extra item "WRKSRC" placed in the PORTNAME section.
 Makefile: extra item "USE_GITHUB" placed in the PORTNAME section.
 Makefile: extra item "GH_ACCOUNT" placed in the PORTNAME section.
 Makefile: extra item "GH_TAGNAME" placed in the PORTNAME section.
 /data/fernape_data/FreeBSD-repos/ports/comms/spandsp/files/patch-Makefile.am: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


Thanks!
Comment 2 Dustin Marquess 2021-10-13 21:43:08 UTC
Created attachment 228681 [details]
Fixed patch

Fixes up portlint complaintd
Comment 3 Dustin Marquess 2021-10-13 21:44:30 UTC
Updated the patch to fix all portlint complaints, sorry for missing those!

Sadly, the only real "changelog" I can find are the actual commit log in GitHub. There IS a ChangeLog file, but they haven't updated that since FreeSWITCH took over maintenance of spandsp, it appears :(.
Comment 4 Daniel Engberg freebsd_committer 2021-10-14 09:31:51 UTC
Make sure to set sane optimization and that the configure script doesn't make assumptions based on the buildbox.
Comment 5 Daniel Engberg freebsd_committer 2021-10-14 10:39:50 UTC
..also upon further review PORTVERSION is also incorrect (bogus) as far as I can tell?

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description
"Example 19. Using USE_GITHUB to Access a Commit Between Two Versions"

Should be more suitable?
Comment 6 Fernando Apesteguía freebsd_committer 2021-10-14 11:54:22 UTC
Created attachment 228693 [details]
Proposed patch

Reorder variables
Add USES=jpeg
Remove WRKSRC
Comment 7 Fernando Apesteguía freebsd_committer 2021-10-14 11:56:51 UTC
(In reply to Daniel Engberg from comment #5)
The project upstream does not provide any tags either so we can't use git describe:

~/tmp/spandsp$ git describe --tags 284fe91
fatal: No names found, cannot describe anything.

PORTVERSION here follows the .so major number. I don't know of a better way to do this.

About the configure script, can you clarify?

Thanks!
Comment 8 Daniel Engberg freebsd_committer 2021-10-14 12:56:00 UTC
(In reply to Fernando Apesteguía from comment #7)

Ahh, my bad... In that case I'd suggest 3.0.0.gCOMMITDATE such as 3.0.0.g20211010 (see net/sems) as we're not really packaging 3.0.0?

As for the optimization I noticed this https://github.com/freeswitch/spandsp/pull/20 and the configure script. Upon further inspection it seems like it's all disconnected / not complete so we don't need to worry about it at all. :-)

It would be nice if we could git rid of the static library too but in that case you'd also need to adjust  misc/libsupertone to not build a static library as far as I can tell.

Don't forgot to check users =)
Comment 9 Fernando Apesteguía freebsd_committer 2021-10-14 13:11:47 UTC
Created attachment 228696 [details]
Proposed patch

Switch to DISTVERSION and add commit date.

Dustin, since you are going to take care of the port, what do you think?

For the record, comms/spandsp, net/freeswitch**, multimedia/gstreamer1-plugins  and net/sems build fine in 12.2 and 13.0.

** net/freeswitch fails to package even with current comms/spandsp 0.0.6. But it builds with the new library version.

Tests in current are running now...
Comment 10 Fernando Apesteguía freebsd_committer 2021-10-14 13:12:31 UTC
(In reply to Daniel Engberg from comment #8)
Thanks for the link, I wasn't aware of that bug.
Comment 11 Dustin Marquess 2021-10-15 03:18:09 UTC
(In reply to Fernando Apesteguía from comment #9)

LGTM!

I'd love to remove the static lib too!

I've never used libsupertone personally, but I can look into it.

This whole thing started because I wanted to update to the latest FreeSWITCH (and Kamailio), as as you found out, the newer versions of FS just won't compile with 0.0.6 anymore.
Comment 12 Fernando Apesteguía freebsd_committer 2021-10-15 10:29:56 UTC
(In reply to Dustin Marquess from comment #11)
Hi Dustin,

The .so library provided by the port will change from .2 to .3 so a PORTREVISION bump would be required for the dependent ports.

Would you add that to the most current patch?

Thanks!