Bug 259006 - net-mgmt/sdig: fix build with -fno-common
Summary: net-mgmt/sdig: fix build with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-08 14:53 UTC by Robert Clausecker
Modified: 2021-10-27 16:13 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (zi)
yasu: merge-quarterly+

Attachments
net-mgmt/sdig: fix build with -fno-common (3.89 KB, patch)
2021-10-08 14:53 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-10-08 14:53:14 UTC 
Created attachment 228518 [details]
net-mgmt/sdig: fix build with -fno-common

Since FreeBSD 13 has been released, -fno-common is the default option for the C compiler.  This patch removes an unused global variable to make the build succeed with this option.

While we are at it...

 - regenerate the existing patches
 - add USES=autoreconf as the port otherwise fails to build,
   apparently due to a time stamp issue
 - define LICENSE

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2021-10-25 14:58:38 UTC 
Maintainer timeout.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-10-25 14:59:13 UTC 
Comment on attachment 228518 [details]
net-mgmt/sdig: fix build with -fno-common

Maintainer timeout.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-26 00:16:05 UTC 
^Triage: Reset assignee, open to take
Comment 4 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-10-26 08:54:29 UTC 
Take.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-27 15:57:16 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3436c34cf6a6663dce899fe2d33ffdf3abf841f0

commit 3436c34cf6a6663dce899fe2d33ffdf3abf841f0
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-08 14:38:45 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-10-27 15:54:06 +0000

    net-mgmt/sdig: Fix build with -fno-common

    * Add license information
    * Reformat Makefile with portfmt

    PR:             259006
    Approved by:    maintainer timeout (> 2 weeks)
    Differential Revision:  https://reviews.freebsd.org/D32661

 net-mgmt/sdig/Makefile                     | 13 ++++++++-----
 net-mgmt/sdig/files/patch-sdig.conf        |  6 +++---
 net-mgmt/sdig/files/patch-sdig.conf.5      |  8 ++++----
 net-mgmt/sdig/files/patch-src-output.c     |  4 ++--
 net-mgmt/sdig/files/patch-src_sdig.h (new) | 17 +++++++++++++++++
 5 files changed, 34 insertions(+), 14 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-10-27 16:02:20 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=82a0987e8517e98e339ab648bc76fefefc517390

commit 82a0987e8517e98e339ab648bc76fefefc517390
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-08 14:38:45 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-10-27 16:00:35 +0000

    net-mgmt/sdig: Fix build with -fno-common

    * Add license information
    * Reformat Makefile with portfmt

    PR:             259006
    Approved by:    maintainer timeout (> 2 weeks)
    Differential Revision:  https://reviews.freebsd.org/D32661

    (cherry picked from commit 3436c34cf6a6663dce899fe2d33ffdf3abf841f0)

 net-mgmt/sdig/Makefile                     | 13 ++++++++-----
 net-mgmt/sdig/files/patch-sdig.conf        |  6 +++---
 net-mgmt/sdig/files/patch-sdig.conf.5      |  8 ++++----
 net-mgmt/sdig/files/patch-src-output.c     |  4 ++--
 net-mgmt/sdig/files/patch-src_sdig.h (new) | 17 +++++++++++++++++
 5 files changed, 34 insertions(+), 14 deletions(-)
Comment 7 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-10-27 16:13:29 UTC 
Committed and merged to quarterly branch. Thanks!