Bug 259081 - comms/hidapi Do an exp run for the cmake switch
Summary: comms/hidapi Do an exp run for the cmake switch
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-11 21:14 UTC by Thibault Payet
Modified: 2023-03-27 21:31 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2021-10-11 21:14:52 UTC
With the switch to cmake, code that use hidapi with libusb backend will not have to be modified to build on FreeBSD.

Indeed the cmake build will generate a hidapi-libusb.pc pkg-config files, and will ship with libhidapi-libusb.so.

So all ports that depends on it will need to depends of libhidapi-libusb.so
And they will need to be unpatched for FreeBSD: they will need to check for hidapi-libusb like on GNU/Linux instead of hidapi (with pkg-config).

A dirty fix would be to just change the depends to libhidapi-libusb.so and create a symlink of hidapi-libusb.pc to hidapi.pc .
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2021-10-12 07:25:02 UTC
The build system was switched back to autoreconf 5 days ago, see commit:

https://cgit.freebsd.org/ports/commit/?id=a25d8b2a68117b2fae70a8fc46df808b58e5dd60
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2023-02-23 21:29:18 UTC
Back to pool. I no longer maintain this port.
Comment 3 Steven Stallion 2023-02-23 23:40:49 UTC
Steve(In reply to Thibault Payet from comment #0)

Hi Thibault,

Out of curiosity, what are you requesting? HIDAPI supports more than just CMake, and keeping the set of dependencies as small as possible is a nice goal. Personally, I would prefer using manual Makefiles with supplemental .pc's if that is all that is missing.
Comment 4 Steven Stallion 2023-02-23 23:41:39 UTC
(In reply to Steven Stallion from comment #3)

I should check dates more often. Disregard.
Comment 5 Adriaan de Groot freebsd_committer freebsd_triage 2023-03-27 21:31:27 UTC
Closing this one, since it would need an attachment that actually switches the port around to using CMake (and Steven says to prefer the autotools approach). Note that https://github.com/libusb/hidapi/blob/master/BUILD.md now says that CMake is the preferred build, but there's nothing forcing that on ports (yet).