Bug 259151 - misc/team [patch included] fixing ancient code with K&R compatibility layer and bad pointers and non-varargs. Ugh.
Summary: misc/team [patch included] fixing ancient code with K&R compatibility layer a...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joerg Wunsch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-13 18:50 UTC by dgilbert
Modified: 2021-10-13 18:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (joerg)


Attachments
patch for team.c (assumes other patches already applied) (12.64 KB, patch)
2021-10-13 18:50 UTC, dgilbert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dgilbert 2021-10-13 18:50:15 UTC
Created attachment 228676 [details]
patch for team.c (assumes other patches already applied)

I started out to fix a problem that turned out to be not a problem.  On the way I found all manner of really bad things (tm).  It was hard to fathom with the pre-c89 compatibility layer, but then it was also really bad code that assumed 32 bits (ish) with some assumption that quads were long long and pointers mixed in with ints.

Anyways... this cleans up most things, doesn't really change behaviour.