Bug 259170 - audio/mixxx: should not set DOPTIMIZE:STRING=native
Summary: audio/mixxx: should not set DOPTIMIZE:STRING=native
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-14 16:20 UTC by Mikael Urankar
Modified: 2021-11-02 15:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2021-10-14 16:20:33 UTC
march=native isn't valid on several non x86 platforms and causes build failures.

--- a/audio/mixxx/Makefile
+++ b/audio/mixxx/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=      mixxx
 DISTVERSION=   2.3.0
-PORTREVISION=  3
+PORTREVISION=  4
 CATEGORIES=    audio
 
 MAINTAINER=    acm@FreeBSD.org
@@ -47,7 +47,6 @@ USE_QT=               buildtools concurrent core dbus gui linguisttools_build network \
 CONFLICTS=     mixxx22*
 
 CMAKE_ARGS+=   -DINSTALL_USER_UDEV_RULES:BOOL=OFF \
-               -DOPTIMIZE:STRING=native \
                -DBATTERY:BOOL=OFF \
                -DFAAD:BOOL=OFF \
                -DMODPLUG:BOOL=ON \
Comment 1 Daniel Engberg freebsd_committer 2021-10-14 21:04:58 UTC
It will also potentially break on x86 devices as it may enable hardware instructions based on build host that may not be available on target host.
Comment 2 Daniel Engberg freebsd_committer 2021-11-02 15:42:47 UTC
Alternative fix committed by pkubaj@ in commit 09e8de05c7b5230f7dfbc22f985ec39359be3780

Reference: https://cgit.freebsd.org/ports/commit/?id=09e8de05c7b5230f7dfbc22f985ec39359be3780