Bug 259184 - Selecting an address in pf_map_addr is not an error
Summary: Selecting an address in pf_map_addr is not an error
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-15 11:20 UTC by Kajetan Staszkiewicz
Modified: 2021-10-16 12:45 UTC (History)
0 users

See Also:


Attachments
Selecting pf_map_addr is not an error (1.94 KB, application/mbox)
2021-10-15 11:20 UTC, Kajetan Staszkiewicz
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kajetan Staszkiewicz 2021-10-15 11:20:33 UTC
Created attachment 228720 [details]
Selecting pf_map_addr is not an error

When a redirection/nat IP address is selected by pf_map_addr it is logged with PF_DEBUG_MISC level. This one according to the manual means "Generate debug messages for various errors". Selecting an IP address is not an error, it's a normal function of pf for route-to, nat and some other operations. Therefore PF_DEBUG_NOISY level should be choosen which is means "Generate debug messages for common conditions".

If the patch gets accepted, please add the usual footer to commit:

Submitted by: Kajetan Staszkiewicz <vegeta tuxpowered.net>
Sponsored by: InnoGames GmbH
Comment 1 commit-hook freebsd_committer 2021-10-16 12:45:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=498cca14836da0408841cca8101e481e32151886

commit 498cca14836da0408841cca8101e481e32151886
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-10-16 07:32:15 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-10-16 07:32:15 +0000

    pf: selecting pf_map_addr is not an error

    When a redirection/nat IP address is selected by pf_map_addr it is
    logged with PF_DEBUG_MISC level. This one according to the manual means
    "Generate debug messages for various errors". Selecting an IP address is
    not an error, it's a normal function of pf for route-to, nat and some
    other operations. Therefore PF_DEBUG_NOISY level should be choosen which
    is means "Generate debug messages for common conditions".

    PR:             259184
    Submitted by:   Kajetan Staszkiewicz <vegeta tuxpowered.net>
    Sponsored by:   InnoGames GmbH

 sys/netpfil/pf/pf_lb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)