Bug 259201 - astro/geographiclib: cleanup
Summary: astro/geographiclib: cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-16 09:30 UTC by Tatsuki Makino
Modified: 2023-01-21 17:27 UTC (History)
2 users (show)

See Also:
tatsuki_makino: maintainer-feedback+


Attachments
patch for astro/geographiclib (2.51 KB, patch)
2021-10-16 09:30 UTC, Tatsuki Makino
tatsuki_makino: maintainer-approval+
Details | Diff
poudriere log (423.98 KB, text/plain)
2021-10-16 09:31 UTC, Tatsuki Makino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2021-10-16 09:30:38 UTC
Created attachment 228741 [details]
patch for astro/geographiclib

Variables have been sorted to silence portclippy :)
Regenerated distinfo by running make makesum "FORCE_FETCH_ALL=yes" "FETCH_ARGS=-pm".
Comment 1 Tatsuki Makino 2021-10-16 09:31:45 UTC
Created attachment 228742 [details]
poudriere log
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2021-10-16 16:12:31 UTC
Hmm, please don't do this. This just obfuscates the port more which
cannot be the goal.

I've just added support for ignoring entire blocks to portfmt main.
You can wrap the GEOID_* .for loops with

.ifnmake portclippy
...
.endif

if you think it is necessary to silence portclippy's warnings.
This won't work with ports-mgmt/portfmt just yet though.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-30 16:49:19 UTC
What's the status of this PR?
Comment 4 Tatsuki Makino 2022-06-30 20:37:30 UTC
(In reply to Fernando Apesteguía from comment #3)

Currently, the 2.x series, Geographic-2.1, has been released.
The 2.x series has a separate distribution file for each program language implementation, so I am considering whether to limit it to C++ only. Or do something weird :)

If this place can be reused for version updates, it will be continued; if updates are a separate report, it will be closed.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-01 05:23:03 UTC
I rather close this PR then and create new one for the update to 2.x.

Cheers!
Comment 6 Graham Perrin freebsd_committer freebsd_triage 2023-01-21 16:41:24 UTC
Triage: 

* beyond new (status)

* open or close?