Bug 259233 - devel/coursier: account for coursier changes and update to 2.0.16
Summary: devel/coursier: account for coursier changes and update to 2.0.16
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/coursier/coursier/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-17 18:37 UTC by Chris
Modified: 2021-10-27 18:03 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jhyphenkeck)


Attachments
Diff for changes in devel/coursier for new version and structure (2.24 KB, patch)
2021-10-17 18:37 UTC, Chris
no flags Details | Diff
Updated diff to account for new structure and version of coursier (2.26 KB, patch)
2021-10-27 17:14 UTC, Chris
chris: maintainer-approval? (jhyphenkeck)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2021-10-17 18:37:36 UTC
Created attachment 228785 [details]
Diff for changes in devel/coursier for new version and structure

The current version of coursier on ports is 1.1.0-M12. There have been many changes with the project since then. This diff updates not only the version to the latest stable version of coursier (needed for Scala users that use Metals, the Scala language server), and it also updates the way it extracts the artifact. Previously it was grabbing source and taking the coursier executable from the root. That project structure has changed, so that's no longer possible. I instead followed a similar approach to what shells/ammonite does and instead grab the coursier executable from the releases. There has also been a lot of new features added, which is the reason for the pkg-descr change.

I've followed the testing steps in the porters-handbook, everything works, and I believe I have the diff all set to go. This is my first time submitting to ports, so please let me know if there is something else needed.
Comment 1 Robert Clausecker 2021-10-27 16:55:01 UTC
The way your distfile is set up, the name does not change when upstream releases a new version.  This is a bad thing as it means the FreeBSD distfile cache will be unable to cache more than one version of the distfile.

The easiest way to fix this is to set DIST_SUBDIR to something like

    DIST_SUBDIR= ${PORTNAME}-${DISTVERSION}

so each version of the distfile gets its own directory.
Comment 2 Chris 2021-10-27 17:14:36 UTC
Created attachment 229077 [details]
Updated diff to account for new structure and version of coursier
Comment 3 Chris 2021-10-27 17:15:53 UTC
(In reply to Robert Clausecker from comment #1)

Gotcha that makes sense. I went ahead and made that change. Thanks!