Bug 259252 - net-p2p/*rr: Use framework uses=sqlite
Summary: net-p2p/*rr: Use framework uses=sqlite
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-18 19:38 UTC by Dries Michiels
Modified: 2023-07-27 16:11 UTC (History)
1 user (show)

See Also:
michiel: maintainer-feedback+


Attachments
sqliteuses.diff (1.25 KB, patch)
2021-10-18 19:39 UTC, Dries Michiels
no flags Details | Diff
0001-Move-sqlite3-dependency-from-RUN_DEPENDS-to-USES.patch (3.72 KB, patch)
2023-07-27 10:17 UTC, Michiel van Baak Jansen
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2021-10-18 19:38:52 UTC

    
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2021-10-18 19:39:03 UTC
Created attachment 228811 [details]
sqliteuses.diff
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2022-01-28 15:36:42 UTC
I just checked most *rr ports could utilize this change.
Prowlarr too. I was a bit confused for bazarr as we seem to require 		${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR}  but not actually sqlite3 itself?
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2022-01-28 15:37:05 UTC
Lidarr too :)
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2022-01-28 15:51:36 UTC
(In reply to Dries Michiels from comment #2)

Its being pulled in by the python port duh. Seems that that port also doesn't use the framework, pandoras box has been opened.

Michiel are you OK with me changing the /*rr ports as a start?
Comment 5 Michiel van Baak Jansen 2022-01-28 16:00:01 UTC
(In reply to Dries Michiels from comment #4)

Thanks for the patch. Feel free to update it to patch the other arrs as well.
Comment 6 Dries Michiels freebsd_committer freebsd_triage 2022-02-12 16:58:48 UTC
Given we are now hard specifying sqlite3, I'll replace them with uses= sqlite:3, even though uses= sqlite defaults to 3.
Comment 7 Michiel van Baak Jansen 2023-07-27 10:17:17 UTC
Created attachment 243640 [details]
0001-Move-sqlite3-dependency-from-RUN_DEPENDS-to-USES.patch

poudriere ok
runs in production on my setup (13.2 amd64)

The jellyfin update is in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272266 so maybe you want to take that one as well?
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-07-27 16:09:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a3c489568ffb1f0c3ef295a6d4f55ebf1f061145

commit a3c489568ffb1f0c3ef295a6d4f55ebf1f061145
Author:     Michiel van Baak Jansen <michiel@vanbaak.eu>
AuthorDate: 2023-07-27 16:06:35 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2023-07-27 16:07:56 +0000

    net-p2p/*rr: switch to USES for sqlite

    PR:     259252

 net-p2p/lidarr/Makefile   | 6 +++---
 net-p2p/prowlarr/Makefile | 3 ++-
 net-p2p/radarr/Makefile   | 6 +++---
 net-p2p/readarr/Makefile  | 3 ++-
 net-p2p/sonarr/Makefile   | 3 ++-
 5 files changed, 12 insertions(+), 9 deletions(-)
Comment 9 Dries Michiels freebsd_committer freebsd_triage 2023-07-27 16:11:26 UTC
Committed, thanks!