Bug 259395 - audio/welle.io: Add missing USE_QT+=dbus
Summary: audio/welle.io: Add missing USE_QT+=dbus
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL: https://github.com/albrechtl/welle.io
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-24 09:33 UTC by Nico Sonack
Modified: 2021-11-07 06:57 UTC (History)
1 user (show)

See Also:


Attachments
welleio.patch (508 bytes, patch)
2021-10-24 09:33 UTC, Nico Sonack
nsonack: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Sonack 2021-10-24 09:33:21 UTC
Created attachment 228978 [details]
welleio.patch

As discovered during a poudriere testport, I just added the missing
USE_QT+=dbus.

Since depending packages already built dbus, it didn't cause the build
to fail. I guess we don't require a port revision for this change.
Comment 1 Yasuhiro Kimura freebsd_committer 2021-11-07 05:03:57 UTC
Take.
Comment 2 commit-hook freebsd_committer 2021-11-07 06:56:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=23d4b063c91e6bb74eccee450360d3928ca4a17b

commit 23d4b063c91e6bb74eccee450360d3928ca4a17b
Author:     Nico Sonack <nsonack@outlook.com>
AuthorDate: 2021-11-07 06:51:05 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-07 06:55:26 +0000

    audio/welle.io: Add missing 'dbus' to USE_QT

    Don't bump PORTREVISON as this port had already depended upon
    devel/dbus indirectly.

    While I'm here,

    * Pet portclippy
    * Re-format Makefile with portfmt

    PR:             259395

 audio/welle.io/Makefile | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)
Comment 3 Yasuhiro Kimura freebsd_committer 2021-11-07 06:57:59 UTC
Committed with some refinements. Thanks!