Bug 259429 - [lualoader]: "Autoboot in X seconds. [Space] to pausee"
Summary: [lualoader]: "Autoboot in X seconds. [Space] to pausee"
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-25 09:47 UTC by Katsuyuki Miyoshi
Modified: 2023-04-16 02:26 UTC (History)
2 users (show)

See Also:
koobs: mfc-stable13?
koobs: mfc-stable12?
koobs: mfc-stable11-

Attachments
menu.lua.patch (402 bytes, patch)
2021-10-25 09:47 UTC, Katsuyuki Miyoshi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katsuyuki Miyoshi 2021-10-25 09:47:47 UTC 
Created attachment 229013 [details]
menu.lua.patch

The countdown message displayed by "autoboot_delay" is as follows.

==================================================
...
"Autoboot in 11 seconds. [Space] to pause"
"Autoboot in 10 seconds. [Space] to pause"
"Autoboot in 9 seconds. [Space] to pausee"
"Autoboot in 8 seconds. [Space] to pausee"
...
==================================================

The 'e' at the end remains when the number of digits of "time" is decreased.

I think the attached patch will help.

Thanks.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2021-10-25 14:41:05 UTC 
Patch LGTM
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2021-10-25 15:17:52 UTC 
Take. Is "Katsuyuki Miyoshi" <katsubsd@gmail.com> acceptable for attribution?
Comment 3 Katsuyuki Miyoshi 2021-10-26 00:38:02 UTC 
(In reply to Kyle Evans from comment #2)
Yes, I'm acceptable for attribution.
Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-10-26 16:25:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=bb4c691299c5d699cea29e18fef96bda1cef13da

commit bb4c691299c5d699cea29e18fef96bda1cef13da
Author:     Katsuyuki Miyoshi <katsubsd@gmail.com>
AuthorDate: 2021-10-26 16:21:34 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2021-10-26 16:24:29 +0000

    lualoader: fix the autoboot_delay countdown message

    When the timer drops from double to single digits, a spare 'e' is left
    on the end of the line as we don't overwrite it. Include an extra space
    at the end to account for this and overwrite the leftover character.

    PR:             259429
    MFC after:      3 days
    Reviewed by:    emaste

 stand/lua/menu.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-03-09 21:23:04 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=9cb5ea3dd2ec87a08cef3963823a1015611a1b94

commit 9cb5ea3dd2ec87a08cef3963823a1015611a1b94
Author:     Katsuyuki Miyoshi <katsubsd@gmail.com>
AuthorDate: 2021-10-26 16:21:34 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2022-03-09 21:21:54 +0000

    lualoader: fix the autoboot_delay countdown message

    When the timer drops from double to single digits, a spare 'e' is left
    on the end of the line as we don't overwrite it. Include an extra space
    at the end to account for this and overwrite the leftover character.

    PR:             259429

    (cherry picked from commit bb4c691299c5d699cea29e18fef96bda1cef13da)

 stand/lua/menu.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)