Bug 259430 - security/s2n: update to 1.1.2
Summary: security/s2n: update to 1.1.2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-25 09:58 UTC by Felix Palmen
Modified: 2021-10-26 21:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danilo)


Attachments
0001-security-s2n-update-to-1.1.2 (4.54 KB, patch)
2021-10-25 09:58 UTC, Felix Palmen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen 2021-10-25 09:58:05 UTC
Created attachment 229014 [details]
0001-security-s2n-update-to-1.1.2

New upstream version.

As a quick smoketest, I verified devel/aws-c-io build (pd testport) with the new version.
Comment 1 Felix Palmen 2021-10-25 10:36:20 UTC
Added an upstream issue about the two patches that are currently needed:
https://github.com/aws/s2n-tls/issues/3100
Comment 2 Felix Palmen 2021-10-26 11:45:10 UTC
I see you committed a slightly different, but mostly equivalent update already.

Just one remark: Are you sure there should still be a libs2n.so.0? The SONAME in the lib just reads libs2n.so, so I'm not sure there should be a symlink at all – but if there is one, shouldn't it follow the major version number of the source package then?
Comment 3 Danilo Egea Gondolfo freebsd_committer 2021-10-26 19:21:34 UTC
Hi Felix, sorry for that. As you can see in the commit date I was working to update the aws-c* ports for few days and I didn't see your PR.

About the SONAME, you are right, its value actually is "libs2n.so". I'll take a note to remove the symlink when I update it again.
Comment 4 Felix Palmen 2021-10-26 21:23:52 UTC
Hi Danilo, no need to be sorry, that's just coincidence. I'm looking for some sane and simple TLS API for my own project, decided to give s2n a shot, and found the port to be a bit dated, so did sth about it ;) But what counts is the result!

Just FYI: The 'struct tm' issue is already fixed in upstream's master, and they seem to do weekly releases. Let's see where the issue about the missing #include in the examples leads, maybe there's the opportunity to get this free of local patches quite soon :)

Thanks for confirming the symlink is a bit dodgy, given the non-versioned SONAME.