Bug 259434 - editors/kakoune: fix build on armv6/armv7
Summary: editors/kakoune: fix build on armv6/armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://github.com/mawww/kakoune/issu...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-25 11:55 UTC by Robert Clausecker
Modified: 2021-10-25 12:36 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tobik)


Attachments
editors/kakoune: fix build on armv6/armv7 (1.04 KB, patch)
2021-10-25 11:55 UTC, Robert Clausecker
fuz: maintainer-approval? (tobik)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker 2021-10-25 11:55:47 UTC
Created attachment 229019 [details]
editors/kakoune: fix build on armv6/armv7

editors/kakoune has a piece of inline assembly to insert a gdb script into the binary.  Unfortunately this inline assembly causes a syntax error on armv6 and armv7 which can be worked around with a small patch.

Such a patch is attached to this PR and has been tested on armv7 and arm64 FreeBSD 13.0-RELEASE.

The same patch has been submitted to upstream.

https://github.com/mawww/kakoune/issues/4385

Please MFH the patch so we have a working kakoune in the quarterly branch.
Comment 1 Tobias Kortkamp freebsd_committer 2021-10-25 12:33:34 UTC
I'm going to commit it. If I may suggest: please submit a proper pull request
upstream (not just inline in the issue) to make sure it lands (also triggers
their CI etc.). Thanks. :)
Comment 2 commit-hook freebsd_committer 2021-10-25 12:33:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=13c431b0bfec55991792bb215e463584c2fc243d

commit 13c431b0bfec55991792bb215e463584c2fc243d
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-25 11:49:33 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-10-25 12:32:30 +0000

    editors/kakoune: fix build on armv6/armv7

    https://github.com/mawww/kakoune/issues/4385

    PR:             259434

 editors/kakoune/files/patch-src_main.cc (new) | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Comment 3 commit-hook freebsd_committer 2021-10-25 12:35:46 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f89e8c6edef45b5d01cded849018ac652f6f2ef

commit 3f89e8c6edef45b5d01cded849018ac652f6f2ef
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-25 11:49:33 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-10-25 12:35:07 +0000

    editors/kakoune: fix build on armv6/armv7

    https://github.com/mawww/kakoune/issues/4385

    PR:             259434
    (cherry picked from commit 13c431b0bfec55991792bb215e463584c2fc243d)

 editors/kakoune/files/patch-src_main.cc (new) | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)