Bug 259451 - usr.bin/sort: -R not random since src d053fb22f6d3
Summary: usr.bin/sort: -R not random since src d053fb22f6d3
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: Mark Johnston
URL:
Keywords: needs-qa, regression
Depends on:
Blocks:
 
Reported: 2021-10-26 00:30 UTC by sigsys
Modified: 2021-11-01 13:24 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (arichardson)
koobs: mfc-stable13?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sigsys 2021-10-26 00:30:34 UTC
Have a look:
jot 1000 | sort -R | head

Happens on -CURRENT since d053fb22f6d3b6bb0f4e47e4507fefc20cbe0e32.
Comment 1 commit-hook freebsd_committer 2021-10-29 18:32:12 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e9bfb50d5e7aa5d673a5a35318820320c4190d33

commit e9bfb50d5e7aa5d673a5a35318820320c4190d33
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2021-10-29 18:25:42 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2021-10-29 18:29:50 +0000

    sort: Fix random sort

    bwsrawdata() is supposed to return the string buffer.

    PR:             259451
    Reported by:    sigsys@gmail.com
    Fixes:          d053fb22f6d3 ("usr.bin/sort: Avoid UBSan errors")
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation

 usr.bin/sort/bwstring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer 2021-11-01 13:23:45 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=946a297fbd9a01a433f2cfb5fa0ae86df07ee593

commit 946a297fbd9a01a433f2cfb5fa0ae86df07ee593
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2021-10-29 18:25:42 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2021-11-01 13:10:54 +0000

    sort: Fix random sort

    bwsrawdata() is supposed to return the string buffer.

    PR:             259451
    Reported by:    sigsys@gmail.com
    Fixes:          d053fb22f6d3 ("usr.bin/sort: Avoid UBSan errors")
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit e9bfb50d5e7aa5d673a5a35318820320c4190d33)

 usr.bin/sort/bwstring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Mark Johnston freebsd_committer 2021-11-01 13:24:21 UTC
Thanks for the report.