Bug 259485 - Cannot build www/chromium: fails on ffmpeg with CODECS option turned off
Summary: Cannot build www/chromium: fails on ffmpeg with CODECS option turned off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-10-27 15:26 UTC by ml
Modified: 2022-03-22 04:55 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
Full build log (144.00 KB, application/x-bzip)
2021-10-27 15:26 UTC, ml
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ml 2021-10-27 15:26:20 UTC
Created attachment 229072 [details]
Full build log

I'm building Chromium in poudriere on a 12.2/amd64 system with 12.2/amd64 as target and I'm using 2021Q4 port tree.
Build fails since the upgrade to 94.0.4606.81.
I'm attaching the build log.
Comment 1 ml 2021-10-29 06:32:38 UTC
I found out that turning off CODECS options is what causes this.
Comment 2 gnikl 2021-10-29 20:37:29 UTC
Turning the CODECS option off changes the branding and then the ffmpeg config is missing.

The following patch makes the config for the Chromium branding available:

-- cut --
--- Makefile~	2021-10-28 22:13:09.000000000 +0200
+++ Makefile	2021-10-28 22:13:50.719258000 +0200
@@ -271,6 +271,9 @@ pre-configure:
 	${CP} -R \
 		${WRKSRC}/third_party/ffmpeg/chromium/config/Chrome/linux/ \
 		${WRKSRC}/third_party/ffmpeg/chromium/config/Chrome/freebsd
+	${CP} -R \
+		${WRKSRC}/third_party/ffmpeg/chromium/config/Chromium/linux/ \
+		${WRKSRC}/third_party/ffmpeg/chromium/config/Chromium/freebsd
 
 do-configure:
 	# GN generator bootstrapping and generating ninja files
-- cut --
Comment 3 Trond Endrestøl 2022-02-02 16:46:36 UTC
(In reply to gnikl from comment #2)
I can confirm Chromium 97.0.4692.99 does build when the CODECS option is active or when the CODECS option is inactive and the pre-configure target is amended with the three lines as shown in Comment #2.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-03-22 04:55:39 UTC
^Triage: Fixed in v98 update.