Bug 259554 - devel/m4: optionalize INFO
Summary: devel/m4: optionalize INFO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-10-30 16:41 UTC by Val Packett
Modified: 2021-11-21 21:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
0001-devel-m4-optionalize-INFO.patch (2.63 KB, patch)
2021-10-30 16:41 UTC, Val Packett
no flags Details | Diff
0001-devel-m4-optionalize-INFO.patch (2.65 KB, patch)
2021-10-31 10:50 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2021-10-30 16:41:01 UTC
Created attachment 229150 [details]
0001-devel-m4-optionalize-INFO.patch

makeinfo can be an annoying/unwanted build dependency. info pages aren't popular in the BSD world anyway. Maybe let's make them optional here, and disable by default even, like in this patch?
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2021-10-31 03:56:37 UTC
Disable by default is not FreeBSD policy. Optional disable is certainly doable.
Comment 2 Val Packett 2021-10-31 10:50:58 UTC
Created attachment 229168 [details]
0001-devel-m4-optionalize-INFO.patch

Sure, makes sense.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-21 21:21:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=209f8b3d00098482f9079ce3e4482562f4b3621e

commit 209f8b3d00098482f9079ce3e4482562f4b3621e
Author:     Greg V <greg@unrelenting.technology>
AuthorDate: 2021-11-21 21:17:17 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2021-11-21 21:17:17 +0000

    devel/m4: Add INFO option

    PR:             259554

 devel/m4/Makefile                        | 11 +++++++----
 devel/m4/files/extra-patch-no-info (new) | 20 ++++++++++++++++++++
 2 files changed, 27 insertions(+), 4 deletions(-)
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-11-21 21:21:42 UTC
Committed. Thanks!