Bug 259636 - multiple components: Change "Take Affect" to "Take Effect"
Summary: multiple components: Change "Take Affect" to "Take Effect"
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-11-04 00:34 UTC by John Bentley
Modified: 2024-10-03 06:28 UTC (History)
0 users

See Also:

Attachments
diff file, same changes as in the PR referenced above (6.17 KB, patch)
2021-11-04 00:34 UTC, John Bentley 		no flags Details | Diff
diff with edits to contrib files removed (4.20 KB, patch)
2021-11-04 21:20 UTC, John Bentley 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bentley 2021-11-04 00:34:08 UTC 
Created attachment 229257 [details]
diff file, same changes as in the PR referenced above

I believe it's "take effect" as opposed to "take affect". Source: https://www.dictionary.com/e/affect-vs-effect/. I thought this might be worth a patch since it shows up on user-facing menus, specifically the bsdconfig security menu. I made a PR here: https://github.com/freebsd/freebsd-src/pull/559.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-04 01:32:01 UTC 
Thank you for the report and patch John

For those contrib components with active upstreams, we probably want to send these changes upstream too
Comment 2 John Bentley 2021-11-04 21:20:11 UTC 
Created attachment 229275 [details]
diff with edits to contrib files removed

Hi Kubilay,

Thanks for responding!

Makes sense to me to take the contrib changes out of this patch. I updated my PR and have attached an updated diff.

I'm happy to alert the owners of the upstream projects if you think we should. Those are just code comment edits though. Think it would matter to them?

The pared down diff I just attached will still fix all the user-facing menus I believe.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2024-10-03 06:28:26 UTC 
^Triage: clear stale flags.

This change does not appear to have been committed yet.