Bug 259655 - periodic: security/security.functions does not respect ${security_show_success}
Summary: periodic: security/security.functions does not respect ${security_show_success}
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 13.0-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-05 09:07 UTC by Rob LA LAU
Modified: 2021-11-05 21:51 UTC (History)
0 users

See Also:
koobs: mfc-stable13?
koobs: mfc-stable12?
koobs: mfc-stable11-

Attachments
/etc/periodic/security/security.functions : output message unconditionally (499 bytes, patch)
2021-11-05 09:07 UTC, Rob LA LAU 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob LA LAU 2021-11-05 09:07:34 UTC 
Created attachment 229288 [details]
/etc/periodic/security/security.functions : output message unconditionally

Hi,

The check_diff() function in /etc/periodic/security/security.functions only outputs the message if any differences were found.
However, the function should output the message unconditionally, and leave the decision whether or not to display the output to /usr/sbin/periodic; the latter checks the ${security_show_success} variable to make this decision.

Patch attached.

Cheers,
  Rob