Bug 259675 - www/drupal7: files/pkg-message.in uses type: UPGRADE
Summary: www/drupal7: files/pkg-message.in uses type: UPGRADE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-06 13:53 UTC by Dan Langille
Modified: 2024-03-16 11:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2021-11-06 13:53:56 UTC
I think UPGRADE should be upgrade (lower case)

root@aws-1-ingress01:/jails/freshports/usr/ports # grep -r 'type: UPGRADE' *
www/drupal8/files/pkg-message.in:{ type: UPGRADE
www/drupal9/files/pkg-message.in:{ type: UPGRADE
www/drupal7/files/pkg-message.in:{ type: UPGRADE

At https://docs.freebsd.org/en/books/porters-handbook/pkg-files/ it states "The type keyword can have three values:".  UPGRADE is not one of those values.

I'm happy to make these changes but wanted to discuss it first.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2023-07-19 11:35:38 UTC
maintainer timeout
Comment 2 Dan Langille freebsd_committer freebsd_triage 2024-03-14 12:21:47 UTC
drupal8 and drupal9 have been removed from the tree.

drupal10 has been added.
Comment 3 Dan Langille freebsd_committer freebsd_triage 2024-03-14 12:24:28 UTC
acm: are you OK with me fixing this issue in your port too? www/drupal10:

[12:20 pkg01 dvl ~/ports/head/www] % git diff
diff --git a/www/drupal10/files/pkg-message.in b/www/drupal10/files/pkg-message.in
index 9eb0493081d3..34b48d38aded 100644
--- a/www/drupal10/files/pkg-message.in
+++ b/www/drupal10/files/pkg-message.in
@@ -39,7 +39,7 @@ configuration:
 - PHP "session.cache_limiter" is set to "nocache"
 EOM
 }
-{ type: UPGRADE
+{ type: upgrade
   message: <<EOM
 For important information about upgrading from previous versions of Drupal, please
 please see: %%DOCSDIR%%/UPDATE.txt
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2024-03-16 10:05:23 UTC
if you want, you can update it, thx for the ping :-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-03-16 11:31:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0adde04707e050b76e06a0ee65a63766959e8cdf

commit 0adde04707e050b76e06a0ee65a63766959e8cdf
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2024-03-16 11:27:53 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2024-03-16 11:30:04 +0000

    www/drupral{7,10}: adjust files/pkg-message

    Use upgrade, not UPGRADE.
    PR:             259675

 www/drupal10/files/pkg-message.in | 2 +-
 www/drupal7/files/pkg-message.in  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 6 Dan Langille freebsd_committer freebsd_triage 2024-03-16 11:31:48 UTC
Thanks.