Bug 259780 - devel/notcurses: Update to 2.4.9
Summary: devel/notcurses: Update to 2.4.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/dankamongmen/notcu...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-11 14:13 UTC by nick black
Modified: 2021-11-23 09:30 UTC (History)
1 user (show)

See Also:

Attachments
git diff 2.4.8 -> 2.4.9 (1.64 KB, patch)
2021-11-11 14:13 UTC, nick black 		nickblack: maintainer-approval+
Details | Diff
git diff 2.4.8 -> 2.4.9, take two (1.64 KB, patch)
2021-11-22 01:43 UTC, nick black 		nickblack: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nick black 2021-11-11 14:13:18 UTC 
Created attachment 229430 [details]
git diff 2.4.8 -> 2.4.9

This is the last release expected from the 2.x.x series. The next will be 3.0.0, an API-breaking release and new SONAME (3). All material currently marked deprecated will be removed.

I've removed BUILD_TESTING from CMAKE_OFF, since we're using USE_POC and thus have some basic tests generated. I've added USE_DOCTEST to CMAKE_OFF, as I'm not yet prepared for us to build and run notcurses-tester (though it does work on FreeBSD). I've added USE_QRCODEGEN to CMAKE_ON (we were already depending on it) to enable the qrcode functionality.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-12 06:47:45 UTC 
Q/A:  Makefile: [24]: use a tab (not space) after a variable name

Thanks!
Comment 2 nick black 2021-11-22 01:43:04 UTC 
Created attachment 229650 [details]
git diff 2.4.8 -> 2.4.9, take two

Fixed up space -> tab
Comment 3 nick black 2021-11-22 01:43:16 UTC 
Fixed, thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-11-23 09:18:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0065fd437111a1bbb17ef0ab806897e15b956f5d

commit 0065fd437111a1bbb17ef0ab806897e15b956f5d
Author:     Nick Black <nickblack@linux.com>
AuthorDate: 2021-11-22 17:35:27 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-11-23 09:17:01 +0000

    devel/notcurses: Update to 2.4.9

    ChangeLog: https://github.com/dankamongmen/notcurses/releases/tag/v2.4.9

    PR:     259780
    Reported by:    nickblack@linux.com (maintainer)

 devel/notcurses/Makefile |  7 +++++--
 devel/notcurses/distinfo | 10 +++++-----
 2 files changed, 10 insertions(+), 7 deletions(-)
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2021-11-23 09:30:27 UTC 
Committed,

Thanks!