Bug 259809 - cad/ngspice_rework: Eliminate conflict between flavors
Summary: cad/ngspice_rework: Eliminate conflict between flavors
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-13 04:13 UTC by Yuri Victorovich
Modified: 2021-11-13 22:03 UTC (History)
1 user (show)

See Also:
kevinz5000: maintainer-feedback+


Attachments
patch (2.45 KB, patch)
2021-11-13 04:13 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2021-11-13 04:13:29 UTC
Created attachment 229462 [details]
patch

Currently both flavors install headers and .cm files.

This makes them to conflict each other.

The attached patch removes conflicting files from the @x11 flavor allowing the executable to be installed in parallel with libraries.

The executable seems to work in a standalone mode fine, but if it ever needs headers or .cm files the @shlib flavor can always be installed.
Comment 1 Kevin Zheng 2021-11-13 19:54:27 UTC
Approved, thank you for the investigation and fix.
Comment 2 Yuri Victorovich freebsd_committer 2021-11-13 21:59:11 UTC
Committed.

Thanks for the quick approval!
Comment 3 commit-hook freebsd_committer 2021-11-13 22:00:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e3cf001d007c4aa6ed7ac45b7bf14982e2ecb3ce

commit e3cf001d007c4aa6ed7ac45b7bf14982e2ecb3ce
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-11-13 21:49:26 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-11-13 21:59:25 +0000

    cad/ngspice_rework: Eliminate conflict between flavors

    Before both flavors installed headers and .cm files.
    This caused them to conflict with each other.

    This commit removes conflicting files from the @x11 flavor
    allowing the executable to be installed in parallel with libraries.

    The executable seems to work in a standalone mode fine, but if it ever
    needs headers or .cm files the @shlib flavor can always be installed.

    PR:             259809
    Tested by:      kevinz5000@gmail.com

 cad/ngspice_rework/Makefile                       | 19 ++++++++++++-------
 cad/ngspice_rework/{pkg-plist => pkg-plist-shlib} | 10 ++++------
 2 files changed, 16 insertions(+), 13 deletions(-)