Bug 259832 - Missing paragraph in rc-scripting article
Summary: Missing paragraph in rc-scripting article
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sergio Carlavilla Delgado
URL: https://docs.freebsd.org/en/articles/...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2021-11-14 19:02 UTC by Rocky Hotas
Modified: 2021-11-21 20:06 UTC (History)
2 users (show)

See Also:


Attachments
missing_part_of_rc-scripting_article (2.58 KB, patch)
2021-11-14 19:02 UTC, Rocky Hotas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rocky Hotas 2021-11-14 19:02:56 UTC
Created attachment 229491 [details]
missing_part_of_rc-scripting_article

In the article ``Practical rc.d scripting in BSD'' (https://docs.freebsd.org/en/articles/rc-scripting/) some paragraphs are missing: at least, in Section 7 the list of rc.d keywords and the subsequent `Note'. 

These paragraphs are missing even in the first AsciiDoc commit, 989d921f5d4ac8d8b7c831c13b8954ad1901be24.

A diff with the missing part is attached. It is exactly as the original, except for the sentence ``then you need not include this keyword'', which I modified as ``then you need not to include this keyword'', because of grammar. Feel free to adapt it, or to revert it to the original version.

Some additional considerations:

I do not have checked the full text of the original article, so maybe there are some other parts missing. This missing block has a list which could be translated into the ``Description list'' AsciiDoc structure: `https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/#lists'. Maybe the transition to AsciiDoc deleted it for some reason, but this is just a guess.
Comment 1 Sergio Carlavilla Delgado freebsd_committer 2021-11-14 19:18:19 UTC
Thanks for this. After we finish the new documentation portal. We'll check every article and book. Maybe there's something left.
Sorry for the inconvenience and thanks for this catch.
Comment 2 Rocky Hotas 2021-11-14 19:33:59 UTC
(In reply to Sergio Carlavilla Delgado from comment #1)

Ok! No problem and thanks for your feedback.
Comment 3 commit-hook freebsd_committer 2021-11-21 20:06:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=120050663b8dee82c7c2f6d7246392ff0d94ac24

commit 120050663b8dee82c7c2f6d7246392ff0d94ac24
Author:     Rocky Hotas <rockyhotas@post.com>
AuthorDate: 2021-11-21 20:04:38 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2021-11-21 20:04:38 +0000

    Add missing paragraph in rc-scripting article

    PR:             259832
    Approved by:    carlavilla@

 .../content/en/articles/rc-scripting/_index.adoc   | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Comment 4 Sergio Carlavilla Delgado freebsd_committer 2021-11-21 20:06:54 UTC
Fixed. Thanks!