Bug 260027 - net-p2p/amule: aMule 2.3.3 won't build if MONOLITHIC option unset
Summary: net-p2p/amule: aMule 2.3.3 won't build if MONOLITHIC option unset
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Barbara Guida
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-24 17:39 UTC by Jeffery Telford
Modified: 2021-11-25 02:30 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bar)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffery Telford 2021-11-24 17:39:31 UTC
If the MONOLITHIC option is unset aMule won't build and gives the following errors during the package build stage:

===>  Building package for amule-2.3.3
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/Mac_Gray.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/gnome.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/kde4.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/papirus.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/priscilla.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/tango.zip:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/net-p2p/amule/work/stage/usr/local/share/amule/skins/xfce.zip:No such file or directory
*** Error code 1
Comment 1 Jeffery Telford 2021-11-24 17:43:17 UTC
I found those zip file but they're in the /usr/ports/net-p2p/amule/work/aMule-2.3.3/src/skins folder.

Also if I run "make config" again and re-enable the "Monolithic" option and then run "make" it does nothing until I purge the work folder. Usually when I change an option and run make it will rebuild the port. The good news at least it build this time.
Comment 2 Barbara Guida freebsd_committer 2021-11-24 17:49:04 UTC
Can you try after updating your ports tree?
I've committed a fix about an hour ago.
Comment 3 Jeffery Telford 2021-11-25 02:30:41 UTC
It only seems to include the skin zip files if you select MONOLITHIC but I think it should also include the skins even if you just select AMULEGUI as it too would be skinable.

My fix was to add this to the Makefile:

.include <bsd.port.pre.mk>

.if ${PORT_OPTIONS:MAMULEGUI} || ${PORT_OPTIONS:MMONOLITHIC}
PLIST_SUB+=     AMULESKIN=""
.else
PLIST_SUB+=     AMULESKIN="@comment "
.endif


and I changed the PKG-PLIST and edit the lines for the skins to this:

%%AMULESKIN%%%%DATADIR%%/skins/Mac_Gray.zip
%%AMULESKIN%%%%DATADIR%%/skins/gnome.zip
%%AMULESKIN%%%%DATADIR%%/skins/kde4.zip
%%AMULESKIN%%%%DATADIR%%/skins/papirus.zip
%%AMULESKIN%%%%DATADIR%%/skins/priscilla.zip
%%AMULESKIN%%%%DATADIR%%/skins/tango.zip
%%AMULESKIN%%%%DATADIR%%/skins/xfce.zip

and now it includes the zip files in the pkg file if I select just MONOLITHIC or just AMULEGUI.