Bug 260135 - www/webkit2-gtk3: Fails to build (patch) with GSTREAMER=off
Summary: www/webkit2-gtk3: Fails to build (patch) with GSTREAMER=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-30 09:24 UTC by Guido Falsi
Modified: 2022-03-07 03:04 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2021-11-30 09:24:27 UTC 
I happened to have this option unset and after the update to 2.34.2 in commit 	5487f88d70c1 it fails in the patch fase:

=======================<phase: patch          >============================
===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
===>  Patching for webkit2-gtk3-2.34.2
===>  Applying extra patch /usr/ports/www/webkit2-gtk3/files/extra-patch-revert-7c0f13f37ec5
1 out of 3 hunks failed--saving rejects to Source/WebCore/accessibility/AXObjectCache.cpp.rej
===>  FAILED Applying extra patch /usr/ports/www/webkit2-gtk3/files/extra-patch-revert-7c0f13f37ec5
*** Error code 1

Stop.
make: stopped in /usr/ports/www/webkit2-gtk3


I'm not sure what is changed and how to update the patch though.
Comment 1 Bertrand Petit 2021-12-12 05:14:47 UTC 
I confirm the accuracy of this error report as I'm also affected.
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-12-15 10:36:40 UTC 
It looks like patches added in commit f73bc57ac903 are no longer needed.  Just comment out GSTREAMER_EXTRA_PATCHES_OFF and you'd be fine.
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-03-07 03:04:13 UTC 
Should be fixed now with commit edec08c56b94 (forgot to reference PR number in the log).