Bug 260140 - lang/rust: Update to 1.57.0
Summary: lang/rust: Update to 1.57.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Rust Team
URL: https://reviews.freebsd.org/D33190
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-30 15:20 UTC by Tobias Kortkamp
Modified: 2021-12-05 12:37 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rust)
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2021-11-30 15:20:51 UTC
Hi, please do an exp-run of the Rust 1.57.0 update. Thanks.

https://reviews.freebsd.org/D33190
Comment 1 Antoine Brodin freebsd_committer 2021-12-02 09:39:00 UTC
I have this error when trying to apply the patch:

error: new file rust/files/patch-src_bootstrap_lib.rs depends on old contents
Comment 2 Tobias Kortkamp freebsd_committer 2021-12-02 10:31:09 UTC
(In reply to Antoine Brodin from comment #1)
This a bug in Phabricator because I renamed a bunch files, right?

Try taking it from GitHub instead. It applies fine with git am here.
https://github.com/freebsd/freebsd-ports/compare/main...t6:tobik/rust-1.57.0.patch
Comment 3 commit-hook freebsd_committer 2021-12-03 04:52:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4dce4388e4395dbb63a8e20ac9deb578a2ba5689

commit 4dce4388e4395dbb63a8e20ac9deb578a2ba5689
Author:     Tobias Kortkamp <tobik@FreeBSD.org>
AuthorDate: 2021-12-03 04:27:15 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-12-03 04:48:20 +0000

    devel/gitui: Unbreak build with Rust 1.57.0 (D33190)

    error: field is never read: `hash`
      --> asyncgit/src/blame.rs:28:5
       |
    28 |     hash: u64,
       |     ^^^^^^^^^
       |

    note: the lint level is defined here
      --> asyncgit/src/lib.rs:7:5
       |
    7  |     dead_code,
       |     ^^^^^^^^^

    error: field is never read: `hash`
      --> asyncgit/src/diff.rs:41:5
       |
    41 |     hash: u64,
       |     ^^^^^^^^^

    error: field is never read: `request`
      --> asyncgit/src/fetch.rs:28:5
       |
    28 |     request: FetchRequest,
       |     ^^^^^^^^^^^^^^^^^^^^^

    error: field is never read: `request`
      --> asyncgit/src/push.rs:30:5
       |
    30 |     request: PushRequest,
       |     ^^^^^^^^^^^^^^^^^^^^

    error: field is never read: `request`
      --> asyncgit/src/push_tags.rs:26:5
       |
    26 |     request: PushTagsRequest,
       |     ^^^^^^^^^^^^^^^^^^^^^^^^

    error: could not compile `asyncgit` due to 5 previous errors

    http://package22.nyi.freebsd.org/data/130amd64-default-foo/2021-12-02_10h34m54s/logs/errors/gitui-0.16.2_3.log

    PR:             260140

 devel/gitui/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Antoine Brodin freebsd_committer 2021-12-04 19:25:21 UTC
Exp-run looks fine
Comment 5 commit-hook freebsd_committer 2021-12-05 12:36:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=237b36fa2e73986dc19284686e80a47cb329bb6f

commit 237b36fa2e73986dc19284686e80a47cb329bb6f
Author:     Tobias Kortkamp <tobik@FreeBSD.org>
AuthorDate: 2021-11-30 12:54:55 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-12-05 12:35:41 +0000

    lang/rust: Update to 1.57.0

    - Unbreak build with LibreSSL 3.4.x [0]
    - Disable backtrace's libunwind backend on armv* since it or
      libunwind in base seem to be buggy and cause rustc to crash when
      building some consumers [1]
    - Follow rust-nightly in d5f09dc31fcfdb77b69c86b9093bf67ec67653d9
      and reenable hardlinks in the build

    Changes:        https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html
    PR:             259738 [0]
    PR:             259799 [1]
    PR:             260140
    Exp-run by:     antoine
    Differential Revision:  https://reviews.freebsd.org/D33190
    With hat:       rust

 Mk/Uses/cargo.mk                                   |   2 +-
 Mk/bsd.gecko.mk                                    |   2 +-
 lang/rust-bootstrap/Makefile                       |   2 +-
 lang/rust-bootstrap/distinfo                       |   6 +-
 lang/rust/Makefile                                 |   9 +-
 lang/rust/distinfo                                 | 114 ++++++++++-----------
 .../{ => no-hardlinks}/patch-src_bootstrap_lib.rs  |   0
 .../patch-src_bootstrap_native.rs                  |   0
 ...ch-library_backtrace_src_backtrace_mod.rs (new) |  10 ++
 .../files/patch-vendor_cc-1.0.69_src_lib.rs (new)  |  38 +++++++
 .../patch-vendor_openssl-sys_build_main.rs (new)   |  19 ++++
 lang/rust/update.sh                                |  31 ++----
 12 files changed, 144 insertions(+), 89 deletions(-)
Comment 6 Tobias Kortkamp freebsd_committer 2021-12-05 12:37:07 UTC
Thanks.