Bug 260181 - devel/libfixposix: cherry pick from upstream and take maintainership
Summary: devel/libfixposix: cherry pick from upstream and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-02 22:45 UTC by Filipe da Silva Santos
Modified: 2021-12-22 17:03 UTC (History)
1 user (show)

See Also:


Attachments
devel/libfixposix: cherry pick from upstream and take maintainership (2.29 KB, patch)
2021-12-02 22:45 UTC, Filipe da Silva Santos
no flags Details | Diff
devel/libfixposix: cherry pick from upstream and take maintainership (2.41 KB, patch)
2021-12-02 23:02 UTC, Filipe da Silva Santos
no flags Details | Diff
devel/libfixposix: Fix lfp_sendfile() and take maintainership (2.91 KB, patch)
2021-12-03 17:08 UTC, Filipe da Silva Santos
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filipe da Silva Santos 2021-12-02 22:45:21 UTC
Created attachment 229851 [details]
devel/libfixposix: cherry pick from upstream and take maintainership

Since I've been using libfixposix for Common Lisp development, I'd like to take maintainership of it.
Comment 1 Filipe da Silva Santos 2021-12-02 23:02:27 UTC
Created attachment 229852 [details]
devel/libfixposix: cherry pick from upstream and take maintainership

use upstream fix
Comment 2 Filipe da Silva Santos 2021-12-03 17:08:40 UTC
Created attachment 229861 [details]
devel/libfixposix: Fix lfp_sendfile() and take maintainership

In 0.4.3 `libfixposix' show inconsistent behavior in its `sendfile(2)' implementation.

This patch changes `lfp_sendfile()' behavior, mimicking Linux `sendfile(2)', which returns the number of bytes in case of success, instead of just 0.

This will also fix some Common Lisp (out of tree) libraries.
Comment 3 commit-hook freebsd_committer 2021-12-22 17:02:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c67821f8abb937d459cfacac8d0afb0ca7ea0121

commit c67821f8abb937d459cfacac8d0afb0ca7ea0121
Author:     Filipe da Silva Santos <ports@shiori.com.br>
AuthorDate: 2021-12-22 16:43:37 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2021-12-22 17:02:33 +0000

    devel/libfixposix: Import upstream fix

    Changes `lfp_sendfile()' so it mimics Linux sendfile(2), returning on
    success the number of bytes, instead of just 0.  While here, adopt the
    port.

    PR:             260181
    Obtained from:  https://github.com/sionescu/libfixposix/commit/fc5bbe41a574e668ccfafb0f15dddd28f6decd31
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 devel/libfixposix/Makefile                         |  3 +-
 .../files/patch-src_lib_sendfile.c (new)           | 44 ++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)