Created attachment 229862 [details]
patch to bring finance/chiapos to 1.0.6
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
Attachment -> Details -> maintainer-approval [+]
Upstream appears to have released 1.0.7 , which adds 3.10 support.
Accordingly, USES=python:<version-spec> should be scoped to match supported Python versions in the current chiapos port version (3.7-3.9) as a separate commit (and merged) prior to the version update (bumping to 3.7-3.10 for second commit, please update patch)
For the following changes in setup.py:
- ext_modules=[CMakeExtension("chiapos", ".")],
removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources?
Created attachment 229870 [details]
updated to 1.0.7
funny, I make the patch for 1.0.6 and 2 hours later they release 1.0.7.
Created attachment 229871 [details]
correct 1.0.7 patch
updated to 1.0.7, correct file.
(In reply to Kubilay Kocak from comment #1)
>1.0.7 , which adds 3.10 support.
>Accordingly, USES=python:<version-spec> should be scoped to match supported
I had been advised of issues with FreeBSD's framework with ports containing both cmake and python, so this port has no python bits.
>removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources?
I reversed the removal of the tests_require line. However you bring up a good point. Do I even need the setup.py file in this port? Should I remove the entire file?
I could update the patch to delete setup.py. I left the file and edited some things previously because it annoyed me they typed the project name in the setup.py file.
(In reply to risner from comment #4)
Right I forgot. Separate chiapos / py-chiapos ports is fine
It's OK not to remove files that aren't used in build. Just remove patches that are unnecessary.
Could you also explain the patch file changes/removals. This will help committer explain (why) them. Ideally, just post an appropriate commit log message correctly and completely formatted as a comment
Created attachment 229930 [details]
Patch for 1.0.7
Updated to 1.0.7.
I removed the files/Hellman-Makefile because it had been up streamed and on advice I removed the setup.py changes as they are not relevant for the cmake half of this distribution file.
FreeBSD framework has conflicts when a package has cmake and python products, so we need to split them into two ports. This is the cmake half.
(In reply to risner from comment #6)
Can confirm this all passes QA?
* portlint: ??
* testport: ?? (poudriere: freebsd <version/arch>, py*)
* maketest: ??