Bug 260190 - finance/chiapos: Update to 1.0.6
Summary: finance/chiapos: Update to 1.0.6
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-12-03 17:14 UTC by risner
Modified: 2021-12-09 22:44 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (risner)


Attachments
patch to bring finance/chiapos to 1.0.6 (7.39 KB, patch)
2021-12-03 17:14 UTC, risner
no flags Details | Diff
updated to 1.0.7 (8.56 KB, patch)
2021-12-04 03:32 UTC, risner
risner: maintainer-approval+
Details | Diff
correct 1.0.7 patch (8.56 KB, patch)
2021-12-04 03:49 UTC, risner
risner: maintainer-approval+
Details | Diff
Patch for 1.0.7 (6.35 KB, patch)
2021-12-06 00:00 UTC, risner
risner: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description risner 2021-12-03 17:14:06 UTC
Created attachment 229862 [details]
patch to bring finance/chiapos to 1.0.6

updated
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-03 22:12:11 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.

   Attachment -> Details -> maintainer-approval [+]

Review items:

Upstream appears to have released 1.0.7 [1], which adds 3.10 support.

Accordingly, USES=python:<version-spec> should be scoped to match supported Python versions in the current chiapos port version (3.7-3.9) as a separate commit (and merged) prior to the version update (bumping to 3.7-3.10 for second commit, please update patch)

For the following changes in setup.py:

-        tests_require=["pytest"],
-        ext_modules=[CMakeExtension("chiapos", ".")],

removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources?

[1] https://github.com/Chia-Network/chiapos/releases/tag/1.0.7
Comment 2 risner 2021-12-04 03:32:52 UTC
Created attachment 229870 [details]
updated to 1.0.7

funny, I make the patch for 1.0.6 and 2 hours later they release 1.0.7.
Comment 3 risner 2021-12-04 03:49:15 UTC
Created attachment 229871 [details]
correct 1.0.7 patch

updated to 1.0.7, correct file.
Comment 4 risner 2021-12-04 03:58:16 UTC
(In reply to Kubilay Kocak from comment #1)

>1.0.7 [1], which adds 3.10 support.
>Accordingly, USES=python:<version-spec> should be scoped to match supported
I had been advised of issues with FreeBSD's framework with ports containing both cmake and python, so this port has no python bits.

>removing tests_require shouldn't be necessary, and for the latter change, can that be replaced with removing the bundled chiapos sources?
I reversed the removal of the tests_require line. However you bring up a good point. Do I even need the setup.py file in this port? Should I remove the entire file?

I could update the patch to delete setup.py. I left the file and edited some things previously because it annoyed me they typed the project name in the setup.py file.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-05 23:38:09 UTC
(In reply to risner from comment #4)

Right I forgot. Separate chiapos / py-chiapos ports is fine

It's OK not to remove files that aren't used in build. Just remove patches that are unnecessary.

Could you also explain the patch file changes/removals. This will help committer explain (why) them. Ideally, just post an appropriate commit log message correctly  and completely formatted as a comment
Comment 6 risner 2021-12-06 00:00:58 UTC
Created attachment 229930 [details]
Patch for 1.0.7

Updated to 1.0.7.

I removed the files/Hellman-Makefile because it had been up streamed and on advice I removed the setup.py changes as they are not relevant for the cmake half of this distribution file.

FreeBSD framework has conflicts when a package has cmake and python products, so we need to split them into two ports. This is the cmake half.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-09 22:44:09 UTC
(In reply to risner from comment #6)

Can confirm this all passes QA?

 * portlint: ??
 * testport: ?? (poudriere: freebsd <version/arch>, py*)
 * maketest: ??