Bug 260277 - www/http-parser: fix build with enabled WITH_DEBUG
Summary: www/http-parser: fix build with enabled WITH_DEBUG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-08 17:55 UTC by Michael Zhilin
Modified: 2021-12-09 06:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
Git format-patch (1.65 KB, patch)
2021-12-08 17:55 UTC, Michael Zhilin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zhilin freebsd_committer freebsd_triage 2021-12-08 17:55:28 UTC
Created attachment 229978 [details]
Git format-patch

Hi,

In case of WITH_DEBUG, Mk/* files replace target from install_strip to install. As result it triggers unpatched target of Makefile.

This patch corrects install target as well as install_strip (in same way).

Checked in poudriere for 14-current.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-12-09 06:07:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=00f843c0124714c6272631d2d096daa94776ccde

commit 00f843c0124714c6272631d2d096daa94776ccde
Author:     Michael Zhilin <mizhka@FreeBSD.org>
AuthorDate: 2021-12-09 06:06:28 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-12-09 06:06:28 +0000

    www/http-parser: unbreak the port's build against WITH_DEBUG

    When building WITH_DEBUG, bsd.port.mk would change the target from
    `install-strip' to plain `install', thus it must be patched in the
    same way as `install-strip' to avoid using -D option which meaning
    is different in GNU and BSD implementations of install(1).

    PR:     260277

 www/http-parser/files/patch-Makefile | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-12-09 06:09:17 UTC
Patch had been amended, thanks!