Bug 260291 - sysutils/snapraid: update to 12.0
Summary: sysutils/snapraid: update to 12.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL: https://github.com/amadvance/snapraid...
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-12-09 14:17 UTC by Robert Clausecker
Modified: 2021-12-12 05:02 UTC (History)
1 user (show)

See Also:


Attachments
sysutils/snapraid: update to 12.0 (1.33 KB, patch)
2021-12-09 14:17 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-12-09 14:17:52 UTC
Created attachment 229995 [details]
sysutils/snapraid: update to 12.0

Upstream changes:

 - Parallel disk scanning. It's always enabled but it doesn't cover the -m option
   that still process disks sequentially.

Tested with Poudriere on armv7 arm64 FreeBSD 13.
Successfully ran the test suite on arm64 FreeBSD 13.
Comment 1 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-11 08:03:36 UTC
It would be a good idea to prepend @sample directive before the configuration sample file. (See https://docs.freebsd.org/en/books/porters-handbook/plist/#plist-config)

If we do so, PLIST_FILE will look like:

PLIST_FILES=    bin/snapraid \
                man/man1/snapraid.1.gz \
                "@sample etc/snapraid.conf.sample"

Your thoughts?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-12-11 10:28:49 UTC
(In reply to Hiroki Tagato from comment #1)

Hello Mr Hiroki,

The lack of @sample is intentional because the configuration file must be adapted by the user to the system configuration before it can be used.  Using @sample would cause a defective configuration file to be installed, leading to surprising behaviour.

This had been extensively discussed back when the port was originally accepted.
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-12 04:49:50 UTC
(In reply to Robert Clausecker from comment #2)

Understood. Thanks for the clarification.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-12 05:01:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fbf101b36299fb0ad2d2069fcfd45939344f9f75

commit fbf101b36299fb0ad2d2069fcfd45939344f9f75
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-12-12 04:59:06 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2021-12-12 05:01:02 +0000

    sysutils/snapraid: update to 12.0

    Changelog:
    - Parallel disk scanning. It's always enabled but it doesn't cover the
      -m option that still process disks sequentially.
    (https://github.com/amadvance/snapraid/releases/tag/v12.0)

    PR:             260291
    Reported by:    Robert Clausecker <fuz@fuz.su> (maintainer)

 sysutils/snapraid/Makefile | 2 +-
 sysutils/snapraid/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-12 05:02:08 UTC
Committed, thanks!