Bug 260461 - sys.net.if_bridge_test.span failing in CI
Summary: sys.net.if_bridge_test.span failing in CI
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-16 01:30 UTC by Warner Losh
Modified: 2022-11-09 12:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Warner Losh freebsd_committer freebsd_triage 2021-12-16 01:30:32 UTC
sys.net.if_bridge_test.span is failing in CI. Disable it until this can be resolved.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-12-16 01:35:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=7821ef4487f6d8a9aea5b0460ded01563b0d0a6a

commit 7821ef4487f6d8a9aea5b0460ded01563b0d0a6a
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2021-12-16 01:30:41 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2021-12-16 01:32:37 +0000

    tests: sys.net.if_bridge_test.span is failing in CI

    sys.net.if_bridge_test.span has been failing in CI for a while
    now. Disable it until this can be resolved.

    PR:             260461
    Sponsored by:   Netflix

 tests/sys/net/if_bridge_test.sh | 4 ++++
 1 file changed, 4 insertions(+)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-02 13:18:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=e1274b5b2646a49c1e3efce6c9918c99716d3c07

commit e1274b5b2646a49c1e3efce6c9918c99716d3c07
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:58:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-02 10:59:11 +0000

    bridge tests: re-enable span test

    The root cause of the intermittent span test failures has been
    identified as a race between sending the packet and starting the bpf
    capture.
    This is now resolved, so the test can be re-enabled.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 tests/sys/net/if_bridge_test.sh | 5 -----
 1 file changed, 5 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-02 13:18:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=67557372dfef87eb94681a97a4157198efe21992

commit 67557372dfef87eb94681a97a4157198efe21992
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:55:39 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-02 10:59:10 +0000

    tests: make sniffer more robust

    The Sniffer class is often used by test tools such as pft_ping to verify
    that packets actually get sent where they're expected.

    It starts a background thread to capture packets, but this thread needs
    some time to start, leading to intermittent test failures when the
    capture doesn't start before the relevant packet is sent.

    Add a semaphore to ensure the Sniffer constructor doesn't return until
    the capture is actually running.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 tests/sys/netpfil/common/sniffer.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-09 12:10:30 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=97967fc8e63fb9ce65efe62cb87f89e45711dd3c

commit 97967fc8e63fb9ce65efe62cb87f89e45711dd3c
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:55:39 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-09 08:16:57 +0000

    tests: make sniffer more robust

    The Sniffer class is often used by test tools such as pft_ping to verify
    that packets actually get sent where they're expected.

    It starts a background thread to capture packets, but this thread needs
    some time to start, leading to intermittent test failures when the
    capture doesn't start before the relevant packet is sent.

    Add a semaphore to ensure the Sniffer constructor doesn't return until
    the capture is actually running.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 67557372dfef87eb94681a97a4157198efe21992)

 tests/sys/netpfil/common/sniffer.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-11-09 12:10:31 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=b55f1788c9492a473f0160bffd3e5437843c51f7

commit b55f1788c9492a473f0160bffd3e5437843c51f7
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:58:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-09 08:17:07 +0000

    bridge tests: re-enable span test

    The root cause of the intermittent span test failures has been
    identified as a race between sending the packet and starting the bpf
    capture.
    This is now resolved, so the test can be re-enabled.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit e1274b5b2646a49c1e3efce6c9918c99716d3c07)

 tests/sys/net/if_bridge_test.sh | 1 -
 1 file changed, 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-11-09 12:10:32 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1b43f8cd07fc186652ad369ea189498308ce1b4e

commit 1b43f8cd07fc186652ad369ea189498308ce1b4e
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:55:39 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-09 08:17:00 +0000

    tests: make sniffer more robust

    The Sniffer class is often used by test tools such as pft_ping to verify
    that packets actually get sent where they're expected.

    It starts a background thread to capture packets, but this thread needs
    some time to start, leading to intermittent test failures when the
    capture doesn't start before the relevant packet is sent.

    Add a semaphore to ensure the Sniffer constructor doesn't return until
    the capture is actually running.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 67557372dfef87eb94681a97a4157198efe21992)

 tests/sys/netpfil/common/sniffer.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-11-09 12:10:33 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3ef5d1f82c434db62adf9df315954b0f84a6758e

commit 3ef5d1f82c434db62adf9df315954b0f84a6758e
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2022-11-02 10:58:04 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2022-11-09 08:17:08 +0000

    bridge tests: re-enable span test

    The root cause of the intermittent span test failures has been
    identified as a race between sending the packet and starting the bpf
    capture.
    This is now resolved, so the test can be re-enabled.

    PR:             260461
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit e1274b5b2646a49c1e3efce6c9918c99716d3c07)

 tests/sys/net/if_bridge_test.sh | 1 -
 1 file changed, 1 deletion(-)