Created attachment 230294 [details] Patch for changing default PHP version to 8.0 PHP 7.4 has only 23 days of active support left + 1 year of security only. So let's jump to PHP 8.0. Please to an exp-run for changing the default version. We need to check everything with DEPENDS on or USES php.
It'd be a good idea to also get this fix in: bug #251252
There is an issue with xapian: Error: compute_deps_pkg failed to lookup pkgname for databases/php-xapian@php80 processing package xapian-bindings-1.4.18 from databases/xapian-bindings -- Is SUBDIR+=php-xapian@php80 missing in databases/Makefile and does the port provide the 'php80' FLAVOR?
(In reply to Antoine Brodin from comment #2) databases/php-xapian is php 7.X.X only.
Created attachment 230551 [details] Change DEFAULT_VERSION in php.mk There is one more file that needs to be edited to change the DEFAULT version and that is the Mk/Uses/php.mk
This is still not enough, databases/xapian-bindings still has to be patched. Also please combine all patches in 1. I don't want multiple patches for 1 exp-run.
(In reply to Antoine Brodin from comment #5) I am preparing a patch with both in one. Do you want me to put a patch for databases/xapian-bindings in it too? Or should that go to a different patch?
(In reply to Muhammad Moinur Rahman from comment #6) 1 patch covering everything (php.mk bsd.default-versions.mk and xapian)
Created attachment 230571 [details] Change DEFAULT_VERSION of php - Add UPDATING - Change default version in bsd.default-version.mk - Change default clause to php80 ext-dir - Move sodium to common - Fix databases/xapian-bindings
Before doing this exp-run, there are issues with newly introduced php ports: http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_dblib-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_firebird-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_mysql-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_odbc-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_pgsql-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-pdo_sqlite-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-extensions-1.0.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-xmlreader-8.1.1.log http://beefy16.nyi.freebsd.org/data/130amd64-default/b62f24f32e66/logs/php81-xsl-8.1.1.log
(In reply to Antoine Brodin from comment #9) That is related to bug #260744 and can be safely ignored as php81 has not yet been introduced in the php.mk and bsd.default-versions.mk and the errors are related to that.
The xapian patch is not good, the exp-run still fails to start: [00:01:52] Error: compute_deps_pkg failed to lookup pkgname for databases/php-xapian@php80 processing package xapian-bindings-1.4.18 from databases/xapian-bindings -- Is SUBDIR+=php-xapian@php80 missing in databases/Makefile and does the port provide the 'php80' FLAVOR? [00:01:52] Error: compute_deps_pkg failed to lookup existing pkgname for databases/php-xapian@php80 processing package xapian-bindings-1.4.18
Created attachment 230697 [details] Change DEFAULT_VERSION of php - Add UPDATING - Change default version in bsd.default-version.mk - Change default clause to php80 ext-dir - Move sodium to common - Fix databases/xapian-bindings
Some new failure logs: http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/ZendFramework1-1.12.16_1.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/dns-ui-v0.2.7.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/ilias-5.4.25.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/ilias6-php80-6.14.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/moregroupware-0.7.4_3.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/phpgroupware-0.9.16.017.log http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-10_12h38m07s/logs/errors/phpmyfaq-3.0.8.log
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=80f7a0af110fd78a76d430df8d2915501bd8d1c5 commit 80f7a0af110fd78a76d430df8d2915501bd8d1c5 Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-01-10 18:21:05 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-01-10 18:23:24 +0000 Mark ports to IGNORE with new php81 - Mark some additional ports to IGNORE with the upcoming php DEFAULT php80 [1] PR: 260595 [1] Reported by: portmgr (exp-run) [1] Approved by: portmgr (infrastructure blanket) Sponsored by: Bounce Experts databases/xapian-bindings/Makefile | 1 + deskutils/moregroupware/Makefile | 2 +- dns/dns-ui/Makefile | 1 + graphics/php-facedetect/Makefile | 1 + multimedia/php-pHash/Makefile | 4 ++-- net-mgmt/glpi-plugins-fusioninventory-server/Makefile | 1 + www/elgg/Makefile | 3 ++- www/glpi/Makefile | 1 + www/ilias/Makefile | 1 + www/ilias6/Makefile | 1 + www/phpgroupware/Makefile | 2 +- www/phpmyfaq/Makefile | 1 + www/thundersnarf/Makefile | 1 + www/tt-rss/Makefile | 1 + www/zend-framework1/Makefile | 2 +- 15 files changed, 17 insertions(+), 6 deletions(-)
Would be excellent if someone has a moment to review this patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251252 Without it, ports that depend on www/mod_php80 e.g. thru USES=php:web cannot be installed.
(In reply to Antoine Brodin from comment #13) Hi .. Is there any updates?
New failure log: http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-16_19h40m47s/logs/errors/glpi-9.5.5,1.log
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a0b5eb450491d8893bdfed9e50fcc67683d4619f commit a0b5eb450491d8893bdfed9e50fcc67683d4619f Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-01-18 13:45:15 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-01-18 13:45:15 +0000 www/glpi: Ignore with php80 - Requires sodium extension which is not available in php80 - Pet portclippy and portfmt PR: 260595 Reported by: portmgr (exp-run) Approved by: portmgr (infrastructure blanket) Sponsored by: Bounce Experts www/glpi/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
> - Requires sodium extension which is not available in php80 Are you sure? Because its right here: security/php80-sodium :)
(In reply to Torsten Zuehlsdorff from comment #19) Looks like when I committed 81 in the php.mk I moved sodium to the common _USE_PHP_ALL hence this patch is unable to find it now. So let's skip for now and wait for the exp-run to finish. :(
(In reply to Muhammad Moinur Rahman from comment #20) Which exp-run? the results at comment #17 were from the finished exp-run
(In reply to Antoine Brodin from comment #21) I mean rerun after comment #18.
In this case please refresh the patch, I often have rejects applying.
Created attachment 231140 [details] Change DEFAULT_VERSION of php Refresh patch as some other commits modified the previous patch.
I don't know how you refresh the patch, it still has rejects
Created attachment 231186 [details] Change DEFAULT_VERSION of php Refresh patch
Exp-run looks fine
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2e1fdc173831debc50f2c25b86e202c0a4967334 commit 2e1fdc173831debc50f2c25b86e202c0a4967334 Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-01-24 23:41:06 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-01-24 23:41:06 +0000 Change PHP default version to 8.0 - databases/xapian-bindings is a mata port which do not have php:flavors and is unable to be MARKED to IGNORE as one of it's dependent databases/php-xapian do not support php8.0. Hence this creates a circular dependency and it fails to start bulk building. So for now remove PHP from OPTIONS_DEFAULT. PR: 260595 Approved by: ale portmgr(exp-run) Sponsored by: Bounce Experts Mk/Uses/php.mk | 4 ++-- Mk/bsd.default-versions.mk | 2 +- UPDATING | 16 ++++++++++++++++ databases/xapian-bindings/Makefile | 4 +++- 4 files changed, 22 insertions(+), 4 deletions(-)