Bug 260751 - Fixes for FreeBSD documentation-defined dark and high contrast modes
Summary: Fixes for FreeBSD documentation-defined dark and high contrast modes
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sergio Carlavilla Delgado
URL: https://forums.freebsd.org/posts/548477
Keywords: accessibility
: 260773 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-12-28 12:18 UTC by Graham Perrin
Modified: 2022-01-08 23:20 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-12-28 12:18:44 UTC 
Thanks to Joel Bodenmann in FreeBSD Forums for drawing attention to this example: 

<https://docs.freebsd.org/en/books/handbook/cutting-edge/#updating-src-quick-start>, where the numbered explanatory texts are almost completely invisible against a pale background. 

Other examples, found quite easily, include: 

<https://docs.freebsd.org/en/books/handbook/cutting-edge/#freebsdupdate-upgrade>, where the linked text within the note is pale blue on a pale blue background; 

<https://docs.freebsd.org/en/books/faq/#lock-order-reversal>, again the linked text within a note; 

<https://docs.freebsd.org/en/articles/committers-guide/#pgpkeys-create-steps>; 

<https://docs.freebsd.org/en/articles/contributing/#_keep_your_ports_up_to_date>
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2021-12-28 12:43:26 UTC 
It might help to compare this combination: 

* use the menu at the foot of the page to prefer Light

* add/enable Dark Reader <https://addons.mozilla.org/addon/darkreader/> 
  then at a docs.freebsd.org page, switch on.

Mozilla's page for this recommended extension refers to: 

* <https://opensource.org/licenses/mit-license.php>
Comment 2 Shane 2021-12-30 05:25:28 UTC 
*** Bug 260773 has been marked as a duplicate of this bug. ***
Comment 3 Shane 2021-12-30 05:33:08 UTC 
To the first example of light text I want to add

https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting

The variation is the use of class="title" as well as class="content"
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-12-30 12:45:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=0b57fe8cd821b15aaf049a2e480178a375dd7ce4

commit 0b57fe8cd821b15aaf049a2e480178a375dd7ce4
Author:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
AuthorDate: 2021-12-30 12:42:39 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2021-12-30 12:42:39 +0000

    Improve dark and high contrast themes

    PR:             260751
    Submitted by:   Graham Perrin <grahamperrin (AT) gmail.com>

 documentation/themes/beastie/assets/styles/global.scss    | 15 +++++++++++++++
 documentation/themes/beastie/assets/styles/variables.scss | 12 +++++++++---
 2 files changed, 24 insertions(+), 3 deletions(-)
Comment 5 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2021-12-30 12:50:10 UTC 
Fixed the problems.
Thanks for this report :)