Bug 260774 - Add php81 to the tree
Summary: Add php81 to the tree
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-29 02:04 UTC by Muhammad Moinur Rahman
Modified: 2022-01-15 13:16 UTC (History)
9 users (show)

See Also:
ale: maintainer-feedback+


Attachments
Add php81 (2.08 KB, patch)
2021-12-29 02:04 UTC, Muhammad Moinur Rahman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammad Moinur Rahman freebsd_committer freebsd_triage 2021-12-29 02:04:41 UTC
Created attachment 230515 [details]
Add php81

I have prepared a patch and will be adding php81. But we need to add relevant information in Mk/Uses/php.mk to make it work.

- Add php81 to possible FLAVORS of php
- Move ext sodium to USE_PHP_ALL as it is common to all existing versions
- Add 8.1 as Possible values in bsd.default-versions.mk
Comment 1 rainer 2022-01-05 16:32:47 UTC
I don't seem to be able to compile a number extensions:

 - databases/php81-pdo_sqlite
 - textproc/php81-xsl
 - textproc/php81-xmlreader
 - databases/php81-pdo_dblib
 - lang/php81-extensions (obviously due to some dependencies)
 - databases/php81-pdo_mysql
 - databases/php81-pdo_pgsql
 - databases/php81-pdo_obdc
 - databases/php81-pdo_firebird



databases/php81-pdo_pgsql says:

Unknown extension pdo for PHP 81.
*** Error code 1

Stop.
make: stopped in /usr/ports/databases/php81-pdo_pgsql
=>> Cleaning up wrkdir
===>  Cleaning for php81-pdo_pgsql-8.1.1
build of databases/php81-pdo_pgsql | php81-pdo_pgsql-8.1.1 ended at Tue Jan  4 21:10:19 CET 2022
build time: 00:00:01
!!! build failure encountered !!!


This is a 2022Q1 build in poudriere on 13.0-amd64.
Comment 2 Henrik Hudson 2022-01-05 22:00:41 UTC
It looks PHP 8.1 references haven't been added to Mk/Uses/php.mk or bsd.default-versions.mk yet. I'm using poudriere with a git+https ports tree and updated this morning.
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-05 22:18:56 UTC
(In reply to Henrik Hudson from comment #2)
Yes. And this pr is specifically about that and this has been mentioned in the Commit Log. So no point in mentioning that it's not building. :)

Until committed grab and use the patch which should work perfectly as it has been tested multiple times before committing php81*.
Comment 4 Henrik Hudson 2022-01-05 22:28:39 UTC
I'm sorry. I didn't even look at the commit. I assumed it was all the ports, etc.... and not just for the changes to those specific files. My bad.
Comment 5 Henrik Hudson 2022-01-05 23:31:50 UTC
I can confirm PHP81 and extensions build correctly once that patch is applied. thank you.
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-05 23:50:25 UTC
(In reply to Henrik Hudson from comment #5)
Yeap. Hold on to the patch untill this is committed. I have some more to do to remove some compile time warnings but will take care of those after this is committed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-01-10 10:48:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c5a743203c5c76c2b8bc427c22c2ac3bfffd37f8

commit c5a743203c5c76c2b8bc427c22c2ac3bfffd37f8
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-01-10 10:45:26 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-01-10 10:47:32 +0000

    Welcome php81 to the tree

    - Move extension sodium to common as all current supported php versions
      in the tree supports it
    PR: 260774
    Approved by:    ale
    Sponsored by:   Bounce Experts

 Mk/Uses/php.mk             | 16 ++++++++++------
 Mk/bsd.default-versions.mk |  2 +-
 2 files changed, 11 insertions(+), 7 deletions(-)
Comment 8 wolfgang 2022-01-15 12:39:17 UTC
I can confirm that php81 extensions now build fine on MAIN, however they can still not be built on the 2022Q1 branch. Can we please get that patch also applied on the quarterly branch?
Comment 9 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-15 12:46:23 UTC
(In reply to wolfgang from comment #8)
At this point it's not a good idea to merge it as there is not one commit but couple of commits required to merge plus there will be lots of build on the quarterly which we don't want at this point. Sorry for this.
Comment 10 wolfgang 2022-01-15 13:11:57 UTC
Thanks, I see the problem. Do you expect to merge at a later date during this quarter, or should we switch to MAIN until 2022Q2 comes around, if we need these extensions?
Comment 11 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-15 13:16:52 UTC
(In reply to wolfgang from comment #10)
No we are not merging this quarter anymore. Plus we have more stuffs on PHP pending like changing to default php80 plus removing php73 which might break many things in quarter. So if php is very much important to you I would advise on sticking to main until next quarterly.