Bug 261027 - security/munge: Use release archive and rearrange Makefile
Summary: security/munge: Use release archive and rearrange Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-08 06:52 UTC by Daniel Engberg
Modified: 2022-01-25 08:31 UTC (History)
0 users

See Also:
bofh: maintainer-feedback+


Attachments
Patch for munge (1.60 KB, patch)
2022-01-08 06:52 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-01-08 06:52:29 UTC
Created attachment 230811 [details]
Patch for munge

Use release archive as suggested by Porters Handbook, this also removes the need to use USES= autoreconf
Rearrange Makefile to follow Porters Handbook more closely
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-08 07:29:18 UTC
As you are a committer I would request poudriere logs please. :)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-01-08 20:16:17 UTC
Compile and tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-01-19 07:23:39 UTC
Can I commit this change?

Best regards,
Daniel
Comment 4 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-19 20:21:01 UTC
(In reply to Daniel Engberg from comment #3)
Yes although normally I always prefer for testing on all current Tier-1 releases.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-01-24 21:51:33 UTC
Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n247814-f9f5d846b72 (aarch64) (make, make check-plist)
Comment 6 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-01-24 23:34:08 UTC
(In reply to Daniel Engberg from comment #5)
I have already marked it "maintainer-feedback" "+" that means you are free to commit. :)

In case you are feeling trigger happy check another tool called portfmt. It's a linter for ports Makefile. :)
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-01-25 08:30:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b61153eb7c0e354a4fee6c1e9875c0f6cafddbcc

commit b61153eb7c0e354a4fee6c1e9875c0f6cafddbcc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-25 08:24:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-25 08:24:29 +0000

    security/munge: Use release archive and rearrange Makefile

    Use release archive as suggested by Porters Handbook, this also
    removes the need to use USES= autoreconf
    Rearrange Makefile to follow Porters Handbook more closely

    PR:             261027
    Reviewed by:    bofh@ (maintainer)

 security/munge/Makefile | 14 +++++++-------
 security/munge/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 10 deletions(-)
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2022-01-25 08:31:15 UTC
Thanks!