Created attachment 230880 [details] Patch for libtorrent-rasterbar Backport upstream commit d0f7a09adb73157f4c35e870de65935fd331a3a4 Compile and runtime tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist, make test) Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 13.0-RELEASE (i386) Compile tested with qbittorrent on 12.2-RELEASE using Poudriere
(In reply to Daniel Engberg from comment #0) Daniel, Are you sure that stability problems are resolved? This port was updated to 2.x before and after multiple people complained I had to downgrade it back to 1.x. Yuri
I didn't notice this issue intially but I do see doing more testing on 13 with ZFS, https://github.com/arvidn/libtorrent/issues/6522
Daniel, We would only want to switch to 2.x when qBittorrent would recommend this version. This is because of history of issues with 2.x I asked them here: https://github.com/qbittorrent/qBittorrent/discussions/16028 Yuri
I assument it would be working as upstream ships it with 2.0.5 https://www.qbittorrent.org/download.php It seems though as upstream will keep support for 1.X in 4.4 https://github.com/qbittorrent/qBittorrent/issues/15940
...according to upstream this behaviour is by design? https://github.com/arvidn/libtorrent/issues/6522#issuecomment-1009393400
Looking at upstream development I'd say that we wait for 2.0.6 before doing the switch.
There's also a memory loss problem in qBittorrent with libtorrent-1.x: https://github.com/qbittorrent/qBittorrent/issues/16704 This should be resolved before switch to libtorrent-2.x
I have a patch for 2.0.6 but we should at least wait for https://github.com/arvidn/libtorrent/pull/6828 to land and there's also an issue in the test suite, test_create_torrent fails but I haven't had time to look at it.
Reported here: https://github.com/arvidn/libtorrent/issues/6825
Created attachment 233521 [details] Patch for libtorrent-rasterbar v2 (WIP)
https://github.com/arvidn/libtorrent/issues/6831 might also be worth keeping track of due to the upcoming bump of boost libs
(In reply to Daniel Engberg from comment #8) This is now fixed in RC_2_0 branch as of writing (https://github.com/arvidn/libtorrent/commit/13b252e1a435f84ebbdf21452417ce533c810d1f)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f8c7a69a6d2cf354ba9f6a3c83982a6641c1b2d6 commit f8c7a69a6d2cf354ba9f6a3c83982a6641c1b2d6 Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2022-05-28 06:00:57 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2022-05-28 06:07:14 +0000 net-p2p/{,py-}libtorrent-rasterbar: Update 1.2.14 -> 2.0.6-27 Python binding is BROKEN for now. Thanks to Daniel Engberg for suggestion to try the latest commit with -std=c++17. PR: 264278 261090 net-p2p/libtorrent-rasterbar/Makefile | 38 ++++++------ net-p2p/libtorrent-rasterbar/distinfo | 12 +++- net-p2p/libtorrent-rasterbar/pkg-plist | 102 +++++++++++++++++++------------ net-p2p/py-libtorrent-rasterbar/Makefile | 12 +++- net-p2p/py-libtorrent-rasterbar/distinfo | 12 +++- 5 files changed, 111 insertions(+), 65 deletions(-)