Bug 261123 - net-mgmt/darkstat: Update to 3.0.720
Summary: net-mgmt/darkstat: Update to 3.0.720
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/emikulic/darkstat/...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-11 16:42 UTC by Karim Elatov
Modified: 2022-01-12 13:05 UTC (History)
2 users (show)

See Also:
emikulic: maintainer-feedback+


Attachments
patch for update (1.78 KB, patch)
2022-01-11 16:42 UTC, Karim Elatov
no flags Details | Diff
Update to v3.0.721 (1.42 KB, patch)
2022-01-12 11:33 UTC, emikulic
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karim Elatov 2022-01-11 16:42:29 UTC
Created attachment 230922 [details]
patch for update

Updating darkstat port to latest version and moving the source to github ( https://github.com/emikulic/darkstat)

 net-mgmt/darkstat/Makefile | 11 +++++++----
 net-mgmt/darkstat/distinfo |  5 +++--
 2 files changed, 10 insertions(+), 6 deletions(-)
Comment 1 emikulic 2022-01-12 00:19:10 UTC
Maintainer here. I tested this patch and it looks good to me.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 07:32:45 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 3 emikulic 2022-01-12 07:39:26 UTC
https://github.com/emikulic/darkstat/releases/tag/3.0.720 has release notes. I can't seem to edit the URL field.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 07:49:15 UTC
(In reply to emikulic from comment #3)
Thanks!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 08:29:53 UTC
Fails to build:

cc -flto -pipe -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing static/c-ify.c -o c-ify
--- html.o ---
cc  -flto -pipe -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing -c html.c -o html.o
--- favicon.h ---
(echo -n "static const "; cd static && xxd -i favicon.png | grep -v len) >favicon.h
sh: xxd: not found <-----
*** [favicon.h] Error code 1

make[1]: stopped in /wrkdirs/usr/ports/net-mgmt/darkstat/work/darkstat-3.0.720
1 error

^Triage: Please confirm this change passes QA (portlint, poudriere at least)

For details and instructions, see:

https://docs.freebsd.org/en/books/porters-handbook/#testing
Comment 6 emikulic 2022-01-12 10:39:48 UTC
I'm sorry, Fernando. These are growing pains from switching from the previous release engineering approach to just getting code from GitHub. Apparently Karim and I both have vim installed so that papered over the xxd step.

I'm looking into fixing this.
Comment 7 emikulic 2022-01-12 11:33:23 UTC
Created attachment 230947 [details]
Update to v3.0.721

I've replaced the xxd step with a HOST_CC'd binary and tested with:

poudriere jail -c -j v122 -v 12.2-RELEASE
poudriere ports -c -m null -M /usr/ports -p development
poudriere testport -j v122 -p development -o net-mgmt/darkstat
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-01-12 13:03:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=038bcb21cbd11930ab3317a137ec012c3ff3f6f4

commit 038bcb21cbd11930ab3317a137ec012c3ff3f6f4
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-01-12 12:06:19 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-01-12 13:02:05 +0000

    net-mgmt/darkstat: Update to 3.0.720

    ChangeLog: https://github.com/emikulic/darkstat/releases/tag/3.0.720

    PR:     261123
    Reported by:    elatov@gmail.com

 net-mgmt/darkstat/Makefile | 14 +++++++++-----
 net-mgmt/darkstat/distinfo |  5 +++--
 2 files changed, 12 insertions(+), 7 deletions(-)
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 13:04:29 UTC
Committed,

Thanks!
Comment 10 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-12 13:05:04 UTC
(In reply to emikulic from comment #6)
Thanks for the fast response. Do not worry, these things happen.

Cheers!