Bug 261190 - databases/py-ormar: Loosen sqlalchemy version
Summary: databases/py-ormar: Loosen sqlalchemy version
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-01-14 08:14 UTC by Goran Mekić
Modified: 2022-01-24 18:09 UTC (History)
2 users (show)

See Also:
meka: maintainer-feedback+


Attachments
ormar.diff (1016 bytes, patch)
2022-01-14 08:14 UTC, Goran Mekić
no flags Details | Diff
ormar.diff (1.50 KB, patch)
2022-01-24 18:09 UTC, Goran Mekić
meka: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2022-01-14 08:14:13 UTC
Created attachment 230997 [details]
ormar.diff

With the current version specified, every time there's a sqlalchemy update, this port will fall out.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-14 23:35:32 UTC
What is the version specifier in the sources? If they also pin a max version, those also need to be patched, otherwise will result in a run time error
Comment 2 Goran Mekić 2022-01-24 18:08:31 UTC
In https://github.com/collerek/ormar/blob/master/pyproject.toml#L47 they are a bit too specific with the version, in my opinion.

As to pinning, I'm not sure what it means in terms of running the code. I mean, won't ormar use sqlalchemy that if finds?
Comment 3 Goran Mekić 2022-01-24 18:09:11 UTC
Created attachment 231281 [details]
ormar.diff

New version came out in the mean time.