Bug 261265 - net/libproxy: Use upstream release archive
Summary: net/libproxy: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-17 08:31 UTC by Daniel Engberg
Modified: 2022-01-18 23:04 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Patch for libproxy (1.34 KB, patch)
2022-01-17 08:31 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer 2022-01-17 08:31:46 UTC
Created attachment 231067 [details]
Patch for libproxy

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Comment 1 Tobias C. Berner freebsd_committer 2022-01-17 18:50:14 UTC
Moin moin 

Is there some "meanigufl" diff in the two tar-files?
If so, I would also bump the PORTREVISION just to get everyone switched to this.



mfg Tobias
Comment 2 Daniel Engberg freebsd_committer 2022-01-17 22:03:09 UTC
Hi,

No really...

diff -r github-tarball release-tarball
Only in github-tarball/samples/dotnet: Makefile
Only in github-tarball/samples/libcurl: Makefile
Only in github-tarball/samples/vala: Makefile

Best regards,
Daniel
Comment 3 Tobias C. Berner freebsd_committer 2022-01-18 05:11:38 UTC
(In reply to Daniel Engberg from comment #2)
Ship it :)
Comment 4 commit-hook freebsd_committer 2022-01-18 22:58:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0c630095821a60ec815289035f279ee02d9390ff

commit 0c630095821a60ec815289035f279ee02d9390ff
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-18 22:56:00 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-18 22:56:06 +0000

    net/libproxy: Use upstream release archive

    Use upstream release archive as recommended by Porters Handbook
    (USE_GITHUB section)

    PR:             261265
    Reviewed by:    desktop (tcberner)

 net/libproxy/Makefile | 6 +++---
 net/libproxy/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)