Bug 261300 - graphics/libspiro: Use upstream release archive
Summary: graphics/libspiro: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-18 06:39 UTC by Daniel Engberg
Modified: 2022-01-19 07:55 UTC (History)
1 user (show)

See Also:
cyberbotx: maintainer-feedback+


Attachments
Patch for libspiro (4.17 KB, patch)
2022-01-18 06:39 UTC, Daniel Engberg
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer 2022-01-18 06:39:01 UTC
Created attachment 231111 [details]
Patch for libspiro

Use upstream release archive as recommened by Porters Handbook
While at it do some minor changes to Makefile
Comment 1 Daniel Engberg freebsd_committer 2022-01-18 06:39:15 UTC
Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-18 06:43:30 UTC
^Triage: Reporter is committer, assign accordingly
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-18 06:44:38 UTC
Comment on attachment 231111 [details]
Patch for libspiro

I reckon these come under blanket approval (blanket: ports policy, non functional change), but request maintainer-approval nevertheless.
Comment 4 Naram Qashat 2022-01-18 14:24:28 UTC
Looks good to me.
Comment 5 commit-hook freebsd_committer 2022-01-19 07:53:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=874013bdedfba5e55c3c96c8cbc1652a6c092ca0

commit 874013bdedfba5e55c3c96c8cbc1652a6c092ca0
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-01-19 07:45:59 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-01-19 07:52:05 +0000

    graphics/libspiro: Use upstream release archive

    Use upstream release archive as recommened by Porters Handbook
    While at it do some minor changes to Makefile

    PR:             261300
    Reviewed by:    Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

 graphics/libspiro/Makefile                       | 11 ++++----
 graphics/libspiro/distinfo                       |  6 ++---
 graphics/libspiro/files/patch-Makefile.am (gone) | 33 -----------------------
 graphics/libspiro/files/patch-Makefile.in (new)  | 34 ++++++++++++++++++++++++
 4 files changed, 43 insertions(+), 41 deletions(-)