Bug 261303 - devel/bazel029: builds fine on aarch64
Summary: devel/bazel029: builds fine on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-18 12:35 UTC by Ronald Klop
Modified: 2022-01-19 12:03 UTC (History)
2 users (show)

See Also:
aehlig: maintainer-feedback+


Attachments
git diff in devel/bazel029 (623 bytes, patch)
2022-01-18 12:35 UTC, Ronald Klop
ronald-lists: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop 2022-01-18 12:35:18 UTC
Created attachment 231125 [details]
git diff in devel/bazel029

* enable on aarch64
- compiles on Rpi4/14-CURRENT
- make stage-qa ok
Comment 1 Klaus Aehlig 2022-01-18 17:16:04 UTC
Comment on attachment 231125 [details]
git diff in devel/bazel029

Thanks for testing on aarch64. The change looks good.
Comment 2 Klaus Aehlig 2022-01-18 17:19:00 UTC
The change looks good. Can some committer please commit it? Thanks.
Comment 3 Ronald Klop 2022-01-19 09:39:16 UTC
What I see in other PRs is that it is needed to approve the attachment/patch. Then it ends up in some commit-bucket apparently.
Comment 4 Klaus Aehlig 2022-01-19 10:17:09 UTC
(In reply to Ronald Klop from comment #3)

My approval for the patch (already yesterday) apparently was not registered by bugzilla, probably because the request was not assigned to my email address. I don't see what I can do here, but I approve of the patch.
Comment 5 commit-hook freebsd_committer 2022-01-19 11:52:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8ea3b916eaf6678ae7ed57cb8706ebc720011da0

commit 8ea3b916eaf6678ae7ed57cb8706ebc720011da0
Author:     Ronald Klop <ronald-lists@klop.ws>
AuthorDate: 2022-01-19 11:51:23 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-01-19 11:51:23 +0000

    devel/bazel029: Unbreak on aarch64

    PR:             261303
    Approved by:    Klaus Aehlig (maintainer)

 devel/bazel029/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 6 commit-hook freebsd_committer 2022-01-19 12:02:51 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3090d7e0364e9318e6ab9de19e7d606747f26180

commit 3090d7e0364e9318e6ab9de19e7d606747f26180
Author:     Ronald Klop <ronald-lists@klop.ws>
AuthorDate: 2022-01-19 11:51:23 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-01-19 12:01:47 +0000

    devel/bazel029: Unbreak on aarch64

    PR:             261303
    Approved by:    Klaus Aehlig (maintainer)

    (cherry picked from commit 8ea3b916eaf6678ae7ed57cb8706ebc720011da0)

 devel/bazel029/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 7 Mikael Urankar freebsd_committer 2022-01-19 12:03:19 UTC
Thanks