Bug 261348 - [exp-run] Test impact of target local variables
Summary: [exp-run] Test impact of target local variables
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-19 22:23 UTC by Simon J. Gerraty
Modified: 2022-01-29 18:54 UTC (History)
2 users (show)

See Also:
antoine: exp-run+


Attachments
freebsd12-amd64 make binary for test (193.65 KB, application/x-executable)
2022-01-20 17:33 UTC, Simon J. Gerraty
no flags Details
patch bmake to latest plus local variables (386.86 KB, patch)
2022-01-22 23:10 UTC, Simon J. Gerraty
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon J. Gerraty freebsd_committer 2022-01-19 22:23:04 UTC
Test proposed change to bmake to add support for setting target local variables in a manner similar to gmake.

It would be simplest to provide a make binary (built for freebsd12-amd64),
is that feasible?

Otherwise I could re-work the patch against bmake in main,
(it is currently against an as yet not imported version).
Comment 1 Simon J. Gerraty freebsd_committer 2022-01-20 17:33:30 UTC
Created attachment 231181 [details]
freebsd12-amd64 make binary for test

Ideally, use this binary to do exp-run
Comment 2 Antoine Brodin freebsd_committer 2022-01-22 19:57:51 UTC
Can you provide a patch?

(against a supported branch like main, stable/13, stable/12, releng/12.3, releng/12.2...)
Comment 3 Simon J. Gerraty freebsd_committer 2022-01-22 23:10:26 UTC
Created attachment 231243 [details]
patch bmake to latest plus local variables

Re-workinng the patch against main was too hard, so this patch effectively brings main to to latest bmake plus the intended patch.
Comment 4 Simon J. Gerraty freebsd_committer 2022-01-25 02:05:01 UTC
(In reply to Antoine Brodin from comment #2)
Patch attached
Comment 5 Antoine Brodin freebsd_committer 2022-01-27 14:09:11 UTC
Exp-run looks fine, there was no new failure with this patch.
Comment 6 Simon J. Gerraty freebsd_committer 2022-01-29 18:54:22 UTC
Thanks very much