Bug 261416 - multimedia/pipewire: Add PIPEWIRE_JACK option
Summary: multimedia/pipewire: Add PIPEWIRE_JACK option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-23 18:17 UTC by Yuri Victorovich
Modified: 2022-01-26 07:59 UTC (History)
0 users

See Also:
arrowd: maintainer-feedback+


Attachments
patch (2.95 KB, patch)
2022-01-23 18:17 UTC, Yuri Victorovich
no flags Details | Diff
patch (4.20 KB, patch)
2022-01-23 18:44 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2022-01-23 18:17:23 UTC
Created attachment 231251 [details]
patch

The attached patch adds option PIPEWIRE_JACK that enables the corresponding project option to install Jack support.

libjack.so is intentionally not added to USE_LDCONFIG, because I am planning to add general pipewire-jack support.

This would add DEFAULT_VERSIONS+=jack={jack2,pipewire-jack}, USES=jack, and the port audio/jack-proxy. The latter port would depend on either audio/jack or multimedia/pipewire depending on jack choice in DEFAULT_VERSIONS, and it would have the relevant USE_LDCONFIG choice.

The current patch just installs the pipewire-jack files.
Comment 1 Yuri Victorovich freebsd_committer 2022-01-23 18:44:36 UTC
Created attachment 231252 [details]
patch
Comment 2 commit-hook freebsd_committer 2022-01-26 07:58:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d5ab482f0a609d5e62719c3bc97c72d2b113d44

commit 8d5ab482f0a609d5e62719c3bc97c72d2b113d44
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2022-01-26 07:57:09 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2022-01-26 07:58:04 +0000

    multimedia/pipewire: Remove the usage of bsd.port.options.mk

    PR:             261416

 multimedia/pipewire/Makefile  | 6 ------
 multimedia/pipewire/pkg-plist | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)
Comment 3 commit-hook freebsd_committer 2022-01-26 07:58:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37077982c4c244cddcb8afa5a3919bc32ff4e422

commit 37077982c4c244cddcb8afa5a3919bc32ff4e422
Author:     Yuri Victorovich <yuri@freebsd.org>
AuthorDate: 2022-01-26 07:50:43 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2022-01-26 07:58:04 +0000

    multimedia/pipewire: Add PIPEWIRE_JACK option.

    PR:             261416

 multimedia/pipewire/Makefile  | 18 ++++++++++++++----
 multimedia/pipewire/pkg-plist | 10 ++++++++++
 2 files changed, 24 insertions(+), 4 deletions(-)
Comment 4 Gleb Popov freebsd_committer 2022-01-26 07:59:45 UTC
The patch you provided was a bit strange - it had conflicting changes for pkg-plist. Pushed in anyways, thanks!