Created attachment 231434 [details] Patch for databases/clickhouse/Makefile unconditionally pulling in Perl On stable/13 and below this port depends on devel/llvm13 and gets Perl for free. On current this port depends on the system compiler and no Perl gets pulled in. The attached patch fixes this corner case.
I agree, LGTM!
Comment on attachment 231434 [details] Patch for databases/clickhouse/Makefile unconditionally pulling in Perl diff --git a/databases/clickhouse/Makefile b/databases/clickhouse/Makefile index a08b6081557b..4c5b4464d36c 100644 --- a/databases/clickhouse/Makefile +++ b/databases/clickhouse/Makefile @@ -17,7 +17,8 @@ ONLY_FOR_ARCHS_REASON= only supported on aarch64 and amd64 BUILD_DEPENDS= bash:shells/bash RUN_DEPENDS= bash:shells/bash -USES= cmake cpe localbase python shebangfix +USES= cmake cpe localbase perl5 python shebangfix +USE_PERL5= build CPE_VENDOR= yandex
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=387191eefa58cca914159ef850c063b237bc740c commit 387191eefa58cca914159ef850c063b237bc740c Author: Trond Endrestøl <Trond.Endrestol@ximalas.info> AuthorDate: 2022-02-26 01:04:06 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-02-26 01:04:06 +0000 databases/clickhouse: Require Perl to fix build PR: 261561 Approved by: maintainer graphics/epix/Makefile | 2 +- graphics/epix/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
(In reply to commit-hook from comment #4) I'm sorry, but what exactly got committed?
Misdirected commit?
I agree, there was some mistake. Still no changes in the port
just waiting for poudriere to OK this. LGTM.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8b0eb02c2efed83a4207860142a34605621d0e42 commit 8b0eb02c2efed83a4207860142a34605621d0e42 Author: Trond Endrestol <Trond.Endrestol@ximalas.info> AuthorDate: 2022-07-09 19:48:19 +0000 Commit: Dave Cottlehuber <dch@FreeBSD.org> CommitDate: 2022-07-09 19:50:04 +0000 databases/clickhouse: fix build on CURRENT perl5 is pulled in via llvm13 during build, but llvm14 does not have this dependency. Leave PORTREVISION alone as no rebuilds are required. PR: 261561 Approved by: olevole@olevole.ru (maintainer) Sponsored by: SkunkWerks, GmbH databases/clickhouse/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
A commit in branch 2022Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6e616fc4f4cc4f48facd91097626b17b93bfb9d2 commit 6e616fc4f4cc4f48facd91097626b17b93bfb9d2 Author: Trond Endrestol <Trond.Endrestol@ximalas.info> AuthorDate: 2022-07-09 19:48:19 +0000 Commit: Dave Cottlehuber <dch@FreeBSD.org> CommitDate: 2022-07-09 20:10:19 +0000 databases/clickhouse: fix build on CURRENT perl5 is pulled in via llvm13 during build, but llvm14 does not have this dependency. Leave PORTREVISION alone as no rebuilds are required. PR: 261561 Approved by: olevole@olevole.ru (maintainer) Sponsored by: SkunkWerks, GmbH (cherry picked from commit 8b0eb02c2efed83a4207860142a34605621d0e42) databases/clickhouse/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Port appears broken on aarch64 but current release of CH should handle this, so let's address that with a version update.