Bug 261732 - x11/kitty: Update to 0.24.2
Summary: x11/kitty: Update to 0.24.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://sw.kovidgoyal.net/kitty/chang...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-05 11:43 UTC by Alexis Praga
Modified: 2022-02-12 19:58 UTC (History)
3 users (show)

See Also:
alexis.praga: maintainer-feedback+

Attachments
v0.24.2 (826 bytes, patch)
2022-02-05 11:43 UTC, Alexis Praga 		alexis.praga: maintainer-approval+
Details | Diff
patch for v0.24.2 with conditional ncurses (1.52 KB, patch)
2022-02-05 16:04 UTC, Rainer Hurling 		alexis.praga: maintainer-approval+
Details | Diff
patch for v0.24.2 with cond. ncurses + GH release (1.75 KB, patch)
2022-02-12 13:52 UTC, Rainer Hurling 		rhurlin: maintainer-approval? (alexis.praga)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Praga 2022-02-05 11:43:06 UTC 
Created attachment 231563 [details]
v0.24.2

Update to 0.24.2. 

Tested on 13.0 amd64. Changes :
- Allow including config files matching glob patterns in kitty.conf (#4533)
- Shell integration: Fix bash integration not working when PROMPT_COMMAND is used to change the prompt variables (#4476)
- Shell integration: Fix cursor shape not being restored to default when running commands in the shell
- Improve the UI of the ask kitten (#4545)
- Allow customizing the placement and formatting of the tab_activity_symbol and bell_on_tab symbols by adding them to the tab_title_template (#4581, #4507)
- hints kitten: Fix common single letter extension files not being detected (#4491)
- Support dotted and dashed underline styles (#4529)
- For the vertical and horizontal layouts have the windows arranged on a ring rather than a plane. This means the first and last window are considered neighbors (#4494)
- A new action to clear the current selection (#4600)
- Shell integration: fish: Fix cursor shape not working with fish’s vi mode (#4508)
- Shell integration: fish: Dont override fish’s native title setting functionality. See discussion.
- Draw the dots for braille characters more evenly spaced at all font sizes (#4499)
- icat kitten: Add options to mirror images and remove their transparency before displaying them (#4513)
- Fix getting last command output not working correctly when the screen is scrolled (#4522)
- Show number of windows per tab in the select_tab action (#4523)
- Fix clicking in a window to focus it and typing immediately sometimes having unexpected effects if at a shell prompt
(#4128)
- themes kitten: Allow writing to a different file than kitty.conf.
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2022-02-05 16:04:54 UTC 
Created attachment 231566 [details]
patch for v0.24.2 with conditional ncurses

Hi Alexis,
Thanks for your patch with the update to v0.24.2.

Your port is one of the last to unconditionally install ncurses from ports, even if a current ncurses is included in base.Unfortunately, USES=ncurses from Mk/Uses/ncurses.mk does not work sufficiently here.

I added a condition to your patch that installs devel/ncurses only if base does not contain ncurses >= v6.1. This change seems to work as expected and is tested under CURRENT, 13.0 and 12.3, both for i386 and amd64.

If the patch works for you and you agree, I would like to commit it.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-02-06 18:13:46 UTC 
Please also switch to upstream release tarball as mentioned in section "5.4.3. USE_GITHUB" in Porters Handbook

https://github.com/kovidgoyal/kitty/releases/tag/v0.24.2 --> "Source code (cube icon)" --> https://github.com/kovidgoyal/kitty/releases/download/v0.24.2/kitty-0.24.2.tar.xz
Comment 3 Alexis Praga 2022-02-12 10:21:25 UTC 
Comment on attachment 231566 [details]
patch for v0.24.2 with conditional ncurses

It works for me, thanks.
Comment 4 Alexis Praga 2022-02-12 10:23:04 UTC 
(In reply to Daniel Engberg from comment #2)
Hi Daniel,

I'm not sure what to do there as the archive is already downloaded form github using USE_GITHUB.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-02-12 11:39:28 UTC 
I understand that this can be a bit confusing but USE_GITHUB downloads a generated  (on the fly) archive rather than the official static upstream release archive which is why you see a different file name for the distfile. It's not about using github.com as a source but rather using a reproducible (and static in this case) distfile that is less likely to change over time.

See https://cgit.freebsd.org/ports/tree/Mk/bsd.sites.mk#n342 for more information
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2022-02-12 13:52:53 UTC 
Created attachment 231770 [details]
patch for v0.24.2 with cond. ncurses + GH release

My latest patch includes an example of how to fetch the release tarball. 

Note the changes:
- MASTER_SITES with URL to the release location.
- No DISTVERSIONPREFIX required, instead direct use of 'v' in the URL
- USES=tar:xz
- USE_GITHUB not needed here
- distinfo now contains the naming of the release

HTH,
Rainer
Comment 7 Alexis Praga 2022-02-12 15:26:55 UTC 
Comment on attachment 231770 [details]
patch for v0.24.2 with cond. ncurses + GH release

Got it, thanks a lot for the example !
Comment 8 Rainer Hurling freebsd_committer freebsd_triage 2022-02-12 16:13:58 UTC 
(In reply to Alexis Praga from comment #7)

Nice. Do you think we can commit now, with all these changes?
Comment 9 Alexis Praga 2022-02-12 19:43:34 UTC 
Please do, it looks okay on my side :)
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-02-12 19:56:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=179040b024aeaa0ed905257b13565459e492a22f

commit 179040b024aeaa0ed905257b13565459e492a22f
Author:     Alexis Praga <alexis.praga@free.fr>
AuthorDate: 2022-02-12 19:54:00 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2022-02-12 19:54:00 +0000

    x11/kitty: Update to 0.24.2

    Changelog: https://sw.kovidgoyal.net/kitty/changelog/

    PR:             261732

 x11/kitty/Makefile | 16 +++++++++++-----
 x11/kitty/distinfo |  6 +++---
 2 files changed, 14 insertions(+), 8 deletions(-)
Comment 11 Rainer Hurling freebsd_committer freebsd_triage 2022-02-12 19:58:20 UTC 
Committed, thanks :)