Bug 261852 - Teach Phabricator to handle \ in intradiffs
Summary: Teach Phabricator to handle \ in intradiffs
Status: Open
Alias: None
Product: Services
Classification: Unclassified
Component: Code Review (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Some People
Assignee: Phabric Admin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-10 02:45 UTC by Pau Amma
Modified: 2022-11-29 13:44 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pau Amma 2022-02-10 02:45:28 UTC 
(This may be an upstream bug, but since upstream is apparently phasing it out, I'm not sure it's worth reporting there.)

Starting around February 5 and still going on as of a few minutes ago, visiting https://reviews.freebsd.org/D34099/new/ while logged in as myself results in a pop-up reading:

Unhandled Exception ("Exception")

Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file
Comment 1 Pau Amma 2022-07-23 00:45:32 UTC 
Still happens, see https://reviews.freebsd.org/D35819/new/.
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-07-23 02:49:21 UTC 
This problem often occurs if you are not using arc or rather uploading patch files you paste the diffs in the field. This is most likely due to the fact that there should be a blank line at the end of the patch. To distinguish between line feed and line seperator. And most probably while pasting the diff you removed the last line.
Comment 3 Pau Amma 2022-07-26 10:05:33 UTC 
(In reply to Muhammad Moinur Rahman from comment #2)

Well, it's not me doing it, but you seem to be saying it's pilot error and the solution is to add "don't do that" to the documentation. Am I reading you correctly?
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2022-11-29 13:26:30 UTC 
Another case:
https://reviews.freebsd.org/D37528