Bug 261859 - net-mgmt/unpoller: Collect unifi controller data (update MOVED for net-mgmt/unifi-poller)
Summary: net-mgmt/unpoller: Collect unifi controller data (update MOVED for net-mgmt/u...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://unpoller.com/
Keywords: feature
Depends on:
Blocks:
 
Reported: 2022-02-10 11:30 UTC by Ronald Klop
Modified: 2023-09-19 18:07 UTC (History)
2 users (show)

See Also:

Attachments
git diff in /usr/ports (13.63 KB, patch)
2022-02-10 11:30 UTC, Ronald Klop 		no flags Details | Diff
git diff for net-mgmt/unpoller (10.60 KB, patch)
2022-04-12 07:55 UTC, Ronald Klop 		ronald-lists: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald Klop 2022-02-10 11:30:50 UTC 
Created attachment 231708 [details]
git diff in /usr/ports

New port: UnPoller.

Last year net-mgmt/unifi-poller was removed because upstream was gone/changed.
Resurrect the port as net-mgmt/unpoller following the rename upstream.

- poudriere stage-qa ok on aarch64/14-CURRENT & aarch64/13-RELEASE.
- run tested on aarch64/rpi3/13-RELEASE

- fix a double AFFECTS: typo in UPDATING while here.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2022-04-06 13:26:10 UTC 
DISTNAME is never used as the port is using USE_GITHUB.
Comment 2 Ronald Klop 2022-04-12 07:55:46 UTC 
Created attachment 233160 [details]
git diff for net-mgmt/unpoller

(In reply to Mathieu Arnold from comment #1)
Removed DISTNAME from the Makefile.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-09-19 17:32:22 UTC 
Thank you for your submission.  I'm sorry this took so long to be processed.  Here is some feedback on your submission:

 - it would be better to submit a separate port for md2roff and have it be a
   BUILD_DEPENDS.  However, the current approach is ok, although it is unusual.
 - check if you can use the GO_MODULE mechanism and have the Go tooling download
   the dependencies automatically instead of manually listing all tuples.
   This is much easier to maintain in the long run.
 - please remove the "# Created by" comment.  These have been removed from the
   tree.  New "Created by" headers will not be accepted.
 - the rc.d script must be designed such that it can cope with whatever PREFIX
   the user installs the package into.  This is usually achieved through use of 
   the SUB_FILES mechanism, see USE_RC_SUBR in the Porter's Handbook.
   Please check that the rc.d script obeys PREFIX, USERS, and GROUPS.  There's
   also a special rule with respect to installation directory for these, so make
   sure to do it properly.
 - instead of matching against DOCS in do-install, move the installation steps
   for documentation into do-install-DOCS-on.
 - please remove "WWW:" from pkg-descr and put it into the new WWW variable in
   the Makefile.  This is a recent change in the ports infrastructure.
 - please then extend pkg-descr to at least three lines.
 - you seem to be installing the sample configuration twice.  Once is enough.
 - please set LICENSE_FILE if possible.

Please check these issues and resubmit.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-09-19 18:07:47 UTC 
I'll provide textproc/md2roff in a commit in the next few days.