Bug 262389 - net/glib-networking: update to 2.72.0
Summary: net/glib-networking: update to 2.72.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
Depends on:
Reported: 2022-03-06 22:51 UTC by yzrh
Modified: 2022-05-23 15:19 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)

v1 (2.70.1) (1001 bytes, patch)
2022-03-06 22:52 UTC, yzrh
no flags Details | Diff
testport log (68.94 KB, text/plain)
2022-03-06 22:54 UTC, yzrh
no flags Details
v2 (2.72.0) (1.78 KB, patch)
2022-03-26 02:55 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yzrh 2022-03-06 22:51:20 UTC
devel/glib20 and net/glib-networking should have the same
major version, otherwise strange things may happen (such
as ports depending on www/webkit2-gtk3).
Comment 1 yzrh 2022-03-06 22:52:28 UTC
Created attachment 232287 [details]
v1 (2.70.1)
Comment 2 yzrh 2022-03-06 22:54:17 UTC
Created attachment 232288 [details]
testport log
Comment 3 yzrh 2022-03-06 22:54:43 UTC
# portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: "USES" has to appear earlier.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 3 warnings found.
Comment 4 Jan Beich freebsd_committer 2022-03-26 02:55:35 UTC
Created attachment 232727 [details]
v2 (2.72.0)
Comment 5 Jan Beich freebsd_committer 2022-03-26 03:10:24 UTC
glib-networking has only 3 consumers: libsoup, libsoup3, gimp-app. All built fine. However, libsoup has around 121 consumers and many of those have their own consumers. I haven't tested runtime.

attachment 232287 [details] can probably land now while attachment 232727 [details] need to wait for bug 262635. That's assuming someone can confirm "strange things" from comment 0.
Comment 6 Adriaan de Groot freebsd_committer 2022-04-11 18:58:44 UTC
How do we usefully coordinate this update? Clearly glib-networking is de-synced from glib20 (glib20 v2.70.4, glib-networking v2.66.0 in ports main right now), but there's also a glib20 v2.72 update looming -- which will de-sync them even more.

Since the glib20 update is currently not assigned to desktop@ I wouldn't even normally see it.

Based on jbeich@'s comment #5 I'll try to land glib-networking -> 2.70.1 at least.
Comment 7 yzrh 2022-04-12 19:26:09 UTC
(In reply to Jan Beich from comment #5)

For example, when browsing the web with luakit, I am getting loads of:

(<unknown>:36853): GLib-Net-WARNING **: 19:20:24.367: ../tls/gnutls/gtlscertificate-gnutls.c:145: invalid property id 3 for "private-key" of type 'GParamBoxed' in 'GTlsCertificateGnutls'

I am hoping to have some sort of process in place to keep glib and
glib-networking in sync.  Since they do not have the same maintainer,
I don't know how (to keep them in sync).
Comment 8 commit-hook freebsd_committer 2022-04-13 10:35:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37761c5f962e2d7b88d921e8b527f0f1119740d3

commit 37761c5f962e2d7b88d921e8b527f0f1119740d3
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-04-11 22:18:25 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-04-13 10:34:08 +0000

    net/glib-networking: update to 2.70.1 to match glib

    glib-networking and glib (glib20) should be kept in sync
    with major.minor versions. Update to catch up with glib.
    Bump PORTREVISION on direct consumers, but not transitively.

    Note that the PR has a newer patch, but that bumps glib
    by a minor revision as well, to 2.72, which is tricky in itself.

    Transitive consumers of libsoup and libsoup3 all build,
    except for net-im/libnice, but that fails locally without this
    change as well, so I'm going to choose to ignore that.

    PR:             262389
    Obtained from:  yzrh@noema.org

 devel/libsoup/Makefile       | 2 +-
 devel/libsoup3/Makefile      | 2 +-
 graphics/gimp-app/Makefile   | 2 +-
 net/glib-networking/Makefile | 3 +--
 net/glib-networking/distinfo | 6 +++---
 5 files changed, 7 insertions(+), 8 deletions(-)
Comment 9 Adriaan de Groot freebsd_committer 2022-04-13 10:43:06 UTC
**not** closing this one, as the title is for 2.72, which should be landed in-sync with the glib update in the linked PR.
Comment 10 Baptiste Daroussin freebsd_committer 2022-05-19 17:52:46 UTC
I missed this when I landed an update to glib-networking 2.72.0, however, I have been running it just fine with no weird issues with 2.70 and luakit-devel.

Have I missed something ?
Comment 11 Adriaan de Groot freebsd_committer 2022-05-23 15:19:09 UTC
Closing this, since 2.72 has now landed.

I thought, though, that glib and glib-networking should best maintain the same major.minor versions, so don't update one without the other.