Bug 262884 - devel/py-pytest-asyncio: update to 0.18.2
Summary: devel/py-pytest-asyncio: update to 0.18.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks: 256624
  Show dependency treegraph
 
Reported: 2022-03-28 12:27 UTC by Dmitry Marakasov
Modified: 2022-04-08 15:30 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+


Attachments
Patch (1.76 KB, patch)
2022-03-28 12:27 UTC, Dmitry Marakasov
no flags Details | Diff
Patch (1.95 KB, patch)
2022-04-05 11:40 UTC, Dmitry Marakasov
jbeich: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2022-03-28 12:27:01 UTC
Created attachment 232777 [details]
Patch

Update to the latest versions compatible with latest pytest
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2022-03-28 12:28:09 UTC
Jan, please approve this, so I could commit it along with pytest update.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2022-03-30 13:33:25 UTC
Comment on attachment 232777 [details]
Patch

setup.cfg has python_requires = >=3.7, so convert USES=python:3.5+ to USES=python:3.7+

> do-test:
>	@cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -rs -v

Better define like in devel/py-apscheduler for consistency with my ports and to pass TEST_ENV.

Fails to build due to missing BUILD_DEPENDS:

$ poudriere testport -j 130amd64 devel/py-pytest-asyncio
[...]
=======================<phase: configure      >============================
===== env: DEVELOPER_MODE=yes STRICT_DEPENDS=yes
===>   py38-pytest-asyncio-0.18.2 depends on package: py38-setuptools>0 - found
===>   py38-pytest-asyncio-0.18.2 depends on file: /usr/local/bin/python3.8 - found
===>  Configuring for py38-pytest-asyncio-0.18.2
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 33, in __getattr__
    return next(
StopIteration

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 387, in _parse_attr
    return getattr(StaticModule(module_name), attr_name)
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 41, in __getattr__
    raise AttributeError(
AttributeError: pytest_asyncio has no attribute __version__

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 4, in <module>
    setup()
  File "/usr/local/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/local/lib/python3.8/distutils/core.py", line 121, in setup
    dist.parse_config_files()
  File "/usr/local/lib/python3.8/site-packages/setuptools/dist.py", line 772, in parse_config_files
    parse_configuration(self, self.command_options,
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 157, in parse_configuration
    meta.parse()
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 463, in parse
    section_parser_method(section_options)
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 436, in parse_section
    self[name] = value
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 220, in __setitem__
    value = parser(value)
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 557, in _parse_version
    version = self._parse_attr(value, self.package_dir)
  File "/usr/local/lib/python3.8/site-packages/setuptools/config.py", line 390, in _parse_attr
    module = importlib.import_module(module_name)
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/wrkdirs/usr/ports/devel/py-pytest-asyncio/work-py38/pytest-asyncio-0.18.2/pytest_asyncio/__init__.py", line 3, in <module>
    from .plugin import fixture
  File "/wrkdirs/usr/ports/devel/py-pytest-asyncio/work-py38/pytest-asyncio-0.18.2/pytest_asyncio/plugin.py", line 27, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'
*** Error code 1
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2022-04-05 11:40:44 UTC
Created attachment 232957 [details]
Patch

Updated patch:
- Update python min version
- Fix do-test as requested
- Also add missing TEST_DEPENDS
Comment 4 Jan Beich freebsd_committer freebsd_triage 2022-04-05 13:30:38 UTC
Comment on attachment 232957 [details]
Patch

Looks OK. All flavors work fine (@py311 depends on bug 262250 + bug 263060).
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-08 15:29:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c11512de05705ac6b2099551144d1b4f3d0b6e0e

commit c11512de05705ac6b2099551144d1b4f3d0b6e0e
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-03-25 19:14:57 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-04-08 15:27:02 +0000

    devel/py-pytest-asyncio: update to 0.18.2

    PR:             256624, 262884
    Approved by:    jbeich (maintainer)

 devel/py-pytest-asyncio/Makefile | 20 ++++++++++++++++----
 devel/py-pytest-asyncio/distinfo |  6 +++---
 2 files changed, 19 insertions(+), 7 deletions(-)