Bug 262982 - FreeBSD 13.1-RC1 Graphics Not Working
Summary: FreeBSD 13.1-RC1 Graphics Not Working
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 13.1-RELEASE
Hardware: amd64 Any
: --- Affects Some People
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-01 15:16 UTC by Neal Nelson
Modified: 2022-04-08 07:38 UTC (History)
10 users (show)

See Also:


Attachments
dmesg of RC1 (14.77 KB, text/plain)
2022-04-01 15:33 UTC, Neal Nelson
no flags Details
dmesg of working beta3 (15.57 KB, text/plain)
2022-04-01 15:33 UTC, Neal Nelson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Nelson 2022-04-01 15:16:48 UTC
I have a NUC with an 11th generation Tiger Lake processor and it has been working fine with 13.1-BETA3 using graphics/drm-devel-kmod. The Iris-Xe GPU doesn't work with drm-kmod as of yet I believe. I just upgraded to 13.1-RC1 and it's as if it doesn't even try to display any graphics. It doesn't change to the high resolution/small text console mode and of course X fails to run.

As an experiment I installed graphics/drm-kmod, which used to half work then give a blank screen, but it doesn't even try to do that, which is odd.

One difference is that the Intel AX201 WiFi is auto-detected, whereas before it only worked when I loaded everything myself.
Comment 1 Neal Nelson 2022-04-01 15:33:10 UTC
Created attachment 232869 [details]
dmesg of RC1
Comment 2 Neal Nelson 2022-04-01 15:33:48 UTC
Created attachment 232870 [details]
dmesg of working beta3
Comment 3 Neal Nelson 2022-04-01 15:35:46 UTC
I accidentally set the component as USB. There doesn't seem to be one for graphics, so hopefully misc will be OK.
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2022-04-02 09:27:53 UTC
Does recompiling the ports works ?
I believe (but haven't investigated yet) that something in linuxkpi broke the abi.
Comment 5 Neal Nelson 2022-04-02 09:40:19 UTC
It still fails after recompilation, using hte latest ports and src.
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2022-04-02 09:50:40 UTC
I don't see any lines corresponding to drm in your dmesg, can you share the lines when you kldload i915kms ?

Thanks.
Comment 7 Masachika ISHIZUKA 2022-04-02 10:44:50 UTC
(In reply to Neal Nelson from comment #5)
Are you using 5.4.144.g20220223 of drm-fbsd13-kmod ?
It works with drm-fbsd13-kmod-5.4.144.g20220128 on 13.1-BETAs, but it dosen't work on 13.1-RC1.(In reply to Neal Nelson from comment #5)
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2022-04-02 11:23:47 UTC
Recompiling, reinstalling and reloading drm-kmod and dependencies in a 13.1-RC1/amd64 poudriere jail with a 2022Q2 ports tree worked for me, on 13.1-RC1/amd64

Apr  2 12:56:36 e17 pkg[54311]: drm-fbsd13-kmod-5.4.144.g20220128 deinstalled
Apr  2 12:56:41 e17 pkg[54319]: drm-kmod-g20190710_1 deinstalled
Apr  2 12:56:49 e17 pkg[54325]: gpu-firmware-kmod-g20210330 deinstalled
Apr  2 12:57:46 e17 pkg[54340]: gpu-firmware-kmod-g20210330 installed
Apr  2 12:57:46 e17 pkg[54340]: drm-fbsd13-kmod-5.4.144.g20220223 installed
Apr  2 12:57:47 e17 pkg[54340]: drm-kmod-g20190710_1 installed

So drm-fbsd13-kmod got upgraded from 5.4.144.g20220128 to 5.4.144g20220223
Comment 9 Bjoern A. Zeeb freebsd_committer freebsd_triage 2022-04-02 13:47:08 UTC
(In reply to Neal Nelson from comment #0)

Note the change from drm-devel-kmod to drm-kmod on 13.1 both seems odd to me;  does that mean drm was hand-built from ports as well?  In which case this is not a KBI problem I presume.

Can you show us the output of as well please?

grep kld_list /etc/rc.conf
Comment 10 Warner Losh freebsd_committer freebsd_triage 2022-04-02 15:24:07 UTC
This might be our old friend "KBI not stable" between minor releases.
Unlike in the 12.x time frame, though, we've made substantial efforts to keep it stable, but have not test suite that will confirm correctness.
We should make sure that the same sources compiled against a 13.0 kernel FAIL when loaded on a 13.1 kernel and then bisect to find where that stopped working (after my direct commit to stable/13 0437d10e359ea1cbefff8d17cd18ca491dbbd5d7 to restore the 13.0 KBI).
I am mostly AFK this weekend (spring is here!), so someone else needs to do the legwork. There's only 141 commits, so it should be only 9 bisection attempts to find the culprit.
Comment 11 Warner Losh freebsd_committer freebsd_triage 2022-04-02 16:32:48 UTC
oh, wait. 141 commits to linuxkpi, but 2735 to the branch. Still, only 11 or 12 steps to bisecting...
Comment 12 Bjoern A. Zeeb freebsd_committer freebsd_triage 2022-04-02 17:13:06 UTC
(In reply to Warner Losh from comment #11)

Given people say it happened between BTEA3 and RC1 there are very few commits.
I installed an RC1 and pkg installed drm-fbsd13-kmod and the module i915kms.ko loads.

My current guess is that D33915 MFCed with the new struct field at the end ( https://cgit.freebsd.org/src/commit/?h=releng/13.1&id=c325d9edeff568d3d38891b2916bd5bd0e9bf8e3 ) is causing trouble and adjusting the check to be >= 0 for BUS_PROBE_DEFAULT will do the trick ... and it does seem to as now I get drmn0: fb0: i915drmfb frame buffer device ...

I'll deal with this before RC2;  the binary packages are still fine;  the MFC rules and requested solution to the problem in D33915 are not.  Let's take that there.
Comment 13 Bjoern A. Zeeb freebsd_committer freebsd_triage 2022-04-02 17:35:07 UTC
(In reply to Bjoern A. Zeeb from comment #12)


For the clarity of everyone and for something to quote.
The drm-fbd13-kmod binary modules should be fine (though I know little about them).

A changed I merged to stable/13 and 13.1-RC1 prevents the modules from probing (loading).  This will likely look like a silent error.  The drm.ko and the driver module (e.g., i915kms.ko) will be loaded but "nothing happens".

While the fix is not in the tree yet, this should be fixed before RC2.  I'll get email updates or commit messages sent here.
Comment 14 Warner Losh freebsd_committer freebsd_triage 2022-04-02 20:33:12 UTC
https://reviews.freebsd.org/D34754
has what should be a fix.
Comment 16 Neal Nelson 2022-04-08 07:25:15 UTC
Just installed 13.1-RC2 and everything seems to be working again.

Thanks.
Comment 17 Emmanuel Vadot freebsd_committer freebsd_triage 2022-04-08 07:38:24 UTC
Thanks for testing and thanks to the people who fixed this.